diff --git a/stackalytics/tests/unit/test_driverlog.py b/stackalytics/tests/unit/test_driverlog.py index 0afe72bb0..1640a9c51 100644 --- a/stackalytics/tests/unit/test_driverlog.py +++ b/stackalytics/tests/unit/test_driverlog.py @@ -100,7 +100,7 @@ class TestDriverlog(testtools.TestCase): res = list(driverlog.log([review], drivers)) self.assertEqual(1, len(res), 'One CI result is expected') - self.assertEqual(False, res[0]['value']) + self.assertFalse(res[0]['value']) def test_find_ci_result_non_existent(self): drivers = [DRIVER_NON_EXISTENT] @@ -123,4 +123,4 @@ class TestDriverlog(testtools.TestCase): res = list(driverlog.log([review], drivers)) self.assertEqual(1, len(res), 'One CI result is expected') - self.assertEqual(True, res[0]['value']) + self.assertTrue(res[0]['value']) diff --git a/stackalytics/tests/unit/test_rcs.py b/stackalytics/tests/unit/test_rcs.py index ff7279a23..b5b138cb5 100644 --- a/stackalytics/tests/unit/test_rcs.py +++ b/stackalytics/tests/unit/test_rcs.py @@ -43,7 +43,7 @@ class TestRcs(testtools.TestCase): gerrit = rcs.Gerrit('gerrit://review.openstack.org') setup_result = gerrit.setup(username='user', key_filename='key') - self.assertEqual(True, setup_result) + self.assertTrue(setup_result) mock_connect.assert_called_once_with( 'review.openstack.org', port=rcs.DEFAULT_PORT, key_filename='key', username='user') @@ -60,7 +60,7 @@ class TestRcs(testtools.TestCase): gerrit = rcs.Gerrit('gerrit://review.openstack.org') setup_result = gerrit.setup(username='user', key_filename='key') - self.assertEqual(False, setup_result) + self.assertFalse(setup_result) mock_connect.assert_called_once_with( 'review.openstack.org', port=rcs.DEFAULT_PORT, key_filename='key', username='user')