x/stacktach
Code Issues Proposed changes

Merge pull request #46 from SandyWalsh/error_state

Browse Source 
Error state
This commit is contained in:
Sandy Walsh 2013-02-25 08:42:31 -08:00
commit 1ff0e44392
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
reports/pretty.py
View File

@ -81,10 +81,18 @@ def make_report(yesterday=None, start_hour=0, hours=24, percentile=90,
for raw in raws: for raw in raws:
if not start: if not start:
start = raw.when start = raw.when
if 'error' in raw.routing_key: if 'error' in raw.routing_key:
err = raw err = raw
failure_type = 'http' failure_type = 'http'
if raw.old_state != 'error' and raw.state == 'error':
failure_type = 'state'
if raw.old_state == 'error' and \
(not raw.state in ['deleted', 'error']):
failure_type = None
for cmd in cmds: for cmd in cmds:
if cmd in raw.event: if cmd in raw.event:
operation = cmd operation = cmd
@ -140,7 +148,7 @@ def make_report(yesterday=None, start_hour=0, hours=24, percentile=90,
'cells': cells} 'cells': cells}
report.append(details) report.append(details)
failure_types = ["4xx", "5xx", "> 60"] failure_types = ["4xx", "5xx", "> 60", "state"]
cols = ["Operation", "Image", "Min*", "Max*", "Avg*", cols = ["Operation", "Image", "Min*", "Max*", "Avg*",
"Requests"] "Requests"]
for failure_type in failure_types: for failure_type in failure_types:

1
stacktach/views.py
View File

@ -343,7 +343,6 @@ def str_time_to_unix(when):
when = datetime.datetime.strptime(when, "%Y-%m-%d %H:%M:%S") when = datetime.datetime.strptime(when, "%Y-%m-%d %H:%M:%S")
except Exception, e: except Exception, e:
print "BAD DATE: ", e print "BAD DATE: ", e
return dt.dt_to_decimal(when) return dt.dt_to_decimal(when)