From 0b67108debbc756af7113432f44a192b5f7f2337 Mon Sep 17 00:00:00 2001 From: Joshua Hesketh Date: Wed, 11 Sep 2013 14:41:35 +1000 Subject: [PATCH] fix checking reporting overall results based off multiple datasets --- turbo_hipster/task_plugins/gate_real_db_upgrade/task.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/turbo_hipster/task_plugins/gate_real_db_upgrade/task.py b/turbo_hipster/task_plugins/gate_real_db_upgrade/task.py index 4710556..68d9544 100644 --- a/turbo_hipster/task_plugins/gate_real_db_upgrade/task.py +++ b/turbo_hipster/task_plugins/gate_real_db_upgrade/task.py @@ -165,13 +165,14 @@ class Runner(threading.Thread): def _check_all_dataset_logs_for_errors(self): self.log.debug("Check logs for errors") - success = False + success = True for i, dataset in enumerate(self.job_datasets): # Look for the beginning of the migration start - success, message = \ + dataset_success, message = \ handle_results.check_log_for_errors(dataset['log_file_path'], self.git_path) self.job_datasets[i]['result'] = message + success = False if not dataset_success else success if success: self.work_data['result'] = "SUCCESS"