x/tuskar-ui
Code Issues Proposed changes

Make get_object_by_id() work for most Django objects.

Browse Source 
Django object id is usually an int while lookup is an unicode string.
It works for Openstack but not other Django objects.

This patch makes other standard Django apps reusing Horizon easier.

Change-Id: I436c34e8b17340537f8d201001741d34c933764e
This commit is contained in:
Zhigang Wang 2013-06-22 11:26:41 -04:00
parent 5473ab43c8
commit 4d279b8baf
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
horizon/tables/base.py
View File

@ -1029,10 +1029,20 @@ class DataTable(object):
the ``lookup`` parameter specified. An error will be raised if
the match is not a single data object.
We will convert the object id and ``lookup`` to unicode before
comparison.
Uses :meth:`~horizon.tables.DataTable.get_object_id` internally.
"""
matches = [datum for datum in self.data if
self.get_object_id(datum) == lookup]
if not isinstance(lookup, unicode):
lookup = unicode(str(lookup), 'utf-8')
matches = []
for datum in self.data:
obj_id = self.get_object_id(datum)
if not isinstance(obj_id, unicode):
obj_id = unicode(str(obj_id), 'utf-8')
if obj_id == lookup:
matches.append(datum)
if len(matches) > 1:
raise ValueError("Multiple matches were returned for that id: %s."
% matches)