x/tuskar-ui
Code Issues Proposed changes

Merge "Return a better error message(security_groups)"

Browse Source
This commit is contained in:
Jenkins 2012-12-05 21:48:40 +00:00 committed by Gerrit Code Review
commit c4746aacfa
2 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openstack_dashboard/dashboards/project/access_and_security/security_groups/forms.py
View File

@ -34,6 +34,10 @@ from openstack_dashboard import api
class CreateGroup(forms.SelfHandlingForm):
name = forms.CharField(label=_("Name"),
error_messages={
'required': _('This field is required.'),
'invalid': _("The string may only contain"
" ASCII characters and numbers.")},
validators=[validators.validate_slug])
description = forms.CharField(label=_("Description"))

14
openstack_dashboard/dashboards/project/access_and_security/security_groups/tests.py
View File

@ -81,6 +81,20 @@ class SecurityGroupsViewTests(test.TestCase):
self.assertMessageCount(error=1)
self.assertRedirectsNoFollow(res, INDEX_URL)
def test_create_security_groups_post_wrong_name(self):
sec_group = self.security_groups.first()
self.mox.StubOutWithMock(api, 'security_group_create')
fail_name = sec_group.name + ' invalid'
self.mox.ReplayAll()
formData = {'method': 'CreateGroup',
'name': fail_name,
'description': sec_group.description}
res = self.client.post(SG_CREATE_URL, formData)
self.assertTemplateUsed(res,
'project/access_and_security/security_groups/create.html')
self.assertContains(res, "ASCII")
def test_edit_rules_get(self):
sec_group = self.security_groups.first()
sec_group_list = self.security_groups.list()