1625b16b04
When a flavor deletion is attempted, two checks are necessary: * ensure the flavor is not deployed on an instance * ensure the flavor is not associated with a deployment role This patch adds the second check which was missing. Change-Id: I8c9610a4245b617cae281b44084d1a93b4699c2c Closes-bug: #1302019
249 lines
11 KiB
Python
249 lines
11 KiB
Python
# -*- coding: utf8 -*-
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import contextlib
|
|
|
|
from django.core import urlresolvers
|
|
|
|
from mock import patch, call # noqa
|
|
|
|
from novaclient.v1_1 import servers
|
|
|
|
from horizon import exceptions
|
|
from openstack_dashboard.test.test_data import utils
|
|
from tuskar_ui import api
|
|
from tuskar_ui.test import helpers as test
|
|
from tuskar_ui.test.test_data import tuskar_data
|
|
|
|
|
|
TEST_DATA = utils.TestDataContainer()
|
|
tuskar_data.data(TEST_DATA)
|
|
INDEX_URL = urlresolvers.reverse(
|
|
'horizon:infrastructure:flavors:index')
|
|
CREATE_URL = urlresolvers.reverse(
|
|
'horizon:infrastructure:flavors:create')
|
|
DETAILS_VIEW = 'horizon:infrastructure:flavors:details'
|
|
|
|
|
|
@contextlib.contextmanager
|
|
def _prepare_create():
|
|
flavor = TEST_DATA.novaclient_flavors.first()
|
|
all_flavors = TEST_DATA.novaclient_flavors.list()
|
|
images = TEST_DATA.glanceclient_images.list()
|
|
data = {'name': 'foobar',
|
|
'vcpus': 3,
|
|
'memory_mb': 1024,
|
|
'disk_gb': 40,
|
|
'arch': 'amd64',
|
|
'kernel_image_id': images[0].id,
|
|
'ramdisk_image_id': images[1].id}
|
|
with contextlib.nested(
|
|
patch('tuskar_ui.api.Flavor.create',
|
|
return_value=flavor),
|
|
patch('openstack_dashboard.api.glance.image_list_detailed',
|
|
return_value=(TEST_DATA.glanceclient_images.list(), False)),
|
|
# Inherited code calls this directly
|
|
patch('openstack_dashboard.api.nova.flavor_list',
|
|
return_value=all_flavors),
|
|
) as mocks:
|
|
yield mocks[0], data
|
|
|
|
|
|
class FlavorsTest(test.BaseAdminViewTests):
|
|
|
|
def test_index(self):
|
|
roles = TEST_DATA.tuskarclient_overcloud_roles.list()
|
|
with contextlib.nested(
|
|
patch('openstack_dashboard.api.nova.flavor_list',
|
|
return_value=TEST_DATA.novaclient_flavors.list()),
|
|
patch('openstack_dashboard.api.nova.server_list',
|
|
return_value=([], False)),
|
|
patch('tuskar_ui.api.OvercloudRole.list', return_value=roles),
|
|
) as (flavors_mock, servers_mock, role_list_mock):
|
|
res = self.client.get(INDEX_URL)
|
|
self.assertEqual(flavors_mock.call_count, 1)
|
|
self.assertEqual(servers_mock.call_count, 1)
|
|
self.assertEqual(role_list_mock.call_count, 1)
|
|
|
|
self.assertTemplateUsed(res, 'infrastructure/flavors/index.html')
|
|
|
|
def test_index_recoverable_failure(self):
|
|
with patch('openstack_dashboard.api.nova.flavor_list',
|
|
side_effect=exceptions.Conflict):
|
|
self.client.get(INDEX_URL)
|
|
# FIXME(dtantsur): I expected the following to work:
|
|
# self.assertMessageCount(error=1, warning=0)
|
|
|
|
def test_create_get(self):
|
|
with patch('openstack_dashboard.api.glance.image_list_detailed',
|
|
return_value=([], False)) as mock:
|
|
res = self.client.get(CREATE_URL)
|
|
self.assertEqual(mock.call_count, 2)
|
|
self.assertTemplateUsed(res, 'infrastructure/flavors/create.html')
|
|
|
|
def test_create_get_recoverable_failure(self):
|
|
with patch('openstack_dashboard.api.glance.image_list_detailed',
|
|
side_effect=exceptions.Conflict):
|
|
self.client.get(CREATE_URL)
|
|
self.assertMessageCount(error=1, warning=0)
|
|
|
|
def test_create_post_ok(self):
|
|
images = TEST_DATA.glanceclient_images.list()
|
|
with _prepare_create() as (create_mock, data):
|
|
res = self.client.post(CREATE_URL, data)
|
|
self.assertNoFormErrors(res)
|
|
self.assertRedirectsNoFollow(res, INDEX_URL)
|
|
request = create_mock.call_args_list[0][0][0]
|
|
self.assertListEqual(create_mock.call_args_list, [
|
|
call(request, name=u'foobar', memory=1024, vcpus=3, disk=40,
|
|
cpu_arch='amd64', kernel_image_id=images[0].id,
|
|
ramdisk_image_id=images[1].id)
|
|
])
|
|
|
|
def test_create_post_name_exists(self):
|
|
flavor = TEST_DATA.novaclient_flavors.first()
|
|
with _prepare_create() as (create_mock, data):
|
|
data['name'] = flavor.name
|
|
res = self.client.post(CREATE_URL, data)
|
|
self.assertFormErrors(res)
|
|
|
|
def test_delete_ok(self):
|
|
flavors = TEST_DATA.novaclient_flavors.list()
|
|
data = {'action': 'flavors__delete',
|
|
'object_ids': [flavors[0].id, flavors[1].id]}
|
|
with contextlib.nested(
|
|
patch('openstack_dashboard.api.nova.flavor_delete'),
|
|
patch('openstack_dashboard.api.nova.server_list',
|
|
return_value=([], False)),
|
|
patch('tuskar_ui.api.OvercloudRole.list', return_value=[]),
|
|
patch('openstack_dashboard.api.glance.image_list_detailed',
|
|
return_value=([], False)),
|
|
patch('openstack_dashboard.api.nova.flavor_list',
|
|
return_value=TEST_DATA.novaclient_flavors.list())
|
|
) as (delete_mock, server_list_mock, _role_list_mock, _glance_mock,
|
|
_flavors_mock):
|
|
res = self.client.post(INDEX_URL, data)
|
|
self.assertNoFormErrors(res)
|
|
self.assertRedirectsNoFollow(res, INDEX_URL)
|
|
self.assertEqual(delete_mock.call_count, 2)
|
|
self.assertEqual(server_list_mock.call_count, 1)
|
|
|
|
def test_delete_deployed_on_servers(self):
|
|
flavors = TEST_DATA.novaclient_flavors.list()
|
|
server = servers.Server(
|
|
servers.ServerManager(None),
|
|
{'id': 'aa',
|
|
'name': 'Compute',
|
|
'image': {'id': 1},
|
|
'status': 'ACTIVE',
|
|
'flavor': {'id': flavors[0].id}}
|
|
)
|
|
data = {'action': 'flavors__delete',
|
|
'object_ids': [flavors[0].id, flavors[1].id]}
|
|
with contextlib.nested(
|
|
patch('openstack_dashboard.api.nova.flavor_delete'),
|
|
patch('openstack_dashboard.api.nova.server_list',
|
|
return_value=([server], False)),
|
|
patch('tuskar_ui.api.OvercloudRole.list', return_value=[]),
|
|
patch('openstack_dashboard.api.glance.image_list_detailed',
|
|
return_value=([], False)),
|
|
patch('openstack_dashboard.api.nova.flavor_list',
|
|
return_value=TEST_DATA.novaclient_flavors.list())
|
|
) as (delete_mock, server_list_mock, _role_list_mock, _glance_mock,
|
|
_flavors_mock):
|
|
res = self.client.post(INDEX_URL, data)
|
|
self.assertMessageCount(error=1, warning=0)
|
|
self.assertNoFormErrors(res)
|
|
self.assertRedirectsNoFollow(res, INDEX_URL)
|
|
self.assertEqual(delete_mock.call_count, 1)
|
|
self.assertEqual(server_list_mock.call_count, 1)
|
|
|
|
def test_delete_deployed_on_roles(self):
|
|
flavors = TEST_DATA.novaclient_flavors.list()
|
|
roles = TEST_DATA.tuskarclient_roles_with_flavors.list()
|
|
|
|
data = {'action': 'flavors__delete',
|
|
'object_ids': [flavors[0].id, flavors[1].id]}
|
|
with contextlib.nested(
|
|
patch('openstack_dashboard.api.nova.flavor_delete'),
|
|
patch('openstack_dashboard.api.nova.server_list',
|
|
return_value=([], False)),
|
|
patch('tuskar_ui.api.OvercloudRole.list', return_value=roles),
|
|
patch('openstack_dashboard.api.glance.image_list_detailed',
|
|
return_value=([], False)),
|
|
patch('openstack_dashboard.api.nova.flavor_list',
|
|
return_value=TEST_DATA.novaclient_flavors.list())
|
|
) as (delete_mock, server_list_mock, _role_list_mock, _glance_mock,
|
|
_flavors_mock):
|
|
res = self.client.post(INDEX_URL, data)
|
|
self.assertMessageCount(error=1, warning=0)
|
|
self.assertNoFormErrors(res)
|
|
self.assertRedirectsNoFollow(res, INDEX_URL)
|
|
self.assertEqual(delete_mock.call_count, 1)
|
|
self.assertEqual(server_list_mock.call_count, 1)
|
|
|
|
def test_details_no_overcloud(self):
|
|
flavor = api.Flavor(TEST_DATA.novaclient_flavors.first())
|
|
images = TEST_DATA.glanceclient_images.list()[:2]
|
|
roles = TEST_DATA.tuskarclient_overcloud_roles.list()
|
|
roles[0].flavor_id = flavor.id
|
|
with contextlib.nested(
|
|
patch('openstack_dashboard.api.glance.image_get',
|
|
side_effect=images),
|
|
patch('tuskar_ui.api.Flavor.get',
|
|
return_value=flavor),
|
|
patch('tuskar_ui.api.OvercloudRole.list',
|
|
return_value=roles),
|
|
patch('tuskar_ui.api.Overcloud.get_the_overcloud',
|
|
side_effect=Exception)
|
|
) as (image_mock, get_mock, roles_mock, overcloud_mock):
|
|
res = self.client.get(urlresolvers.reverse(DETAILS_VIEW,
|
|
args=(flavor.id,)))
|
|
self.assertEqual(image_mock.call_count, 1) # memoized
|
|
self.assertEqual(get_mock.call_count, 1)
|
|
self.assertEqual(roles_mock.call_count, 1)
|
|
self.assertEqual(overcloud_mock.call_count, 1)
|
|
self.assertTemplateUsed(res,
|
|
'infrastructure/flavors/details.html')
|
|
|
|
def test_details(self):
|
|
flavor = api.Flavor(TEST_DATA.novaclient_flavors.first())
|
|
images = TEST_DATA.glanceclient_images.list()[:2]
|
|
roles = TEST_DATA.tuskarclient_overcloud_roles.list()
|
|
roles[0].flavor_id = flavor.id
|
|
overcloud = api.Overcloud(TEST_DATA.tuskarclient_overclouds.first())
|
|
with contextlib.nested(
|
|
patch('openstack_dashboard.api.glance.image_get',
|
|
side_effect=images),
|
|
patch('tuskar_ui.api.Flavor.get',
|
|
return_value=flavor),
|
|
patch('tuskar_ui.api.OvercloudRole.list',
|
|
return_value=roles),
|
|
patch('tuskar_ui.api.Overcloud.get_the_overcloud',
|
|
return_value=overcloud),
|
|
# __name__ is required for horizon.tables
|
|
patch('tuskar_ui.api.Overcloud.resources_count',
|
|
return_value=42, __name__='')
|
|
) as (image_mock, get_mock, roles_mock, overcloud_mock, count_mock):
|
|
res = self.client.get(urlresolvers.reverse(DETAILS_VIEW,
|
|
args=(flavor.id,)))
|
|
self.assertEqual(image_mock.call_count, 1) # memoized
|
|
self.assertEqual(get_mock.call_count, 1)
|
|
self.assertEqual(roles_mock.call_count, 1)
|
|
self.assertEqual(overcloud_mock.call_count, 1)
|
|
self.assertEqual(count_mock.call_count, 1)
|
|
self.assertListEqual(count_mock.call_args_list, [call(roles[0])])
|
|
self.assertTemplateUsed(res,
|
|
'infrastructure/flavors/details.html')
|