x/tuskar
Code Issues Proposed changes

Enable gating with flake8 on E121

Browse Source 
Remove the ignore and fix the two minor violations of E121.

Change-Id: If9e3ef2c9994e50306e93394665a67d22c45566e
This commit is contained in:
Dougal Matthews 2014-02-13 13:01:20 +00:00
parent 71201df8e7
commit d41938e4fe
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tox.ini
View File

@ -30,6 +30,6 @@ commands = {posargs}
[flake8] [flake8]
# H302 import only modules. # H302 import only modules.
ignore = E121,E122,E123,E124,E126,E127,E128,H302 ignore = E122,E123,E124,E126,E127,E128,H302
builtins = _ builtins = _
exclude = .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools exclude = .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools

8
tuskar/db/sqlalchemy/models.py
View File

@ -129,8 +129,8 @@ class OvercloudRoleCount(Base):
num_nodes = Column(Integer, nullable=False) num_nodes = Column(Integer, nullable=False)
def __eq__(self, other): def __eq__(self, other):
return self.overcloud_role_id == other.overcloud_role_id \ return (self.overcloud_role_id == other.overcloud_role_id
and self.overcloud_id == other.overcloud_id and self.overcloud_id == other.overcloud_id)
class OvercloudAttribute(Base): class OvercloudAttribute(Base):
@ -156,8 +156,8 @@ class OvercloudAttribute(Base):
value = Column(Text()) value = Column(Text())
def __eq__(self, other): def __eq__(self, other):
return self.overcloud_id == other.overcloud_id \ return (self.overcloud_id == other.overcloud_id
and self.key == other.key and self.key == other.key)
class Overcloud(Base): class Overcloud(Base):