x/valence
Code Issues Proposed changes

Fixed shellcheck error and warning on install_valence.sh

Browse Source 
shellcheck error and warning on install_valence.sh is fixed
and also replaced tab with four spaces for indentation purpose

Change-Id: Id8983045945e12514acb64401502330478b4b8c9
Closes-Bug: #1650699
This commit is contained in:
praveenraj 2016-12-26 11:45:40 +05:30
parent 09207b3977
commit e757bbba41
1 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
install_valence.sh
View File

@ -1,22 +1,23 @@
#!/bin/bash #!/bin/bash
#title :install_valence.sh #title :install_valence.sh
#description :This script will install valence package and deploys conf files #description :This script will install valence package and deploys conf files
#author :Intel Corporation #author :Intel Corporation
#date :17-10-2016 #date :17-10-2016
#version :0.1 #version :0.1
#usage :sudo -E bash install_valence.sh #usage :sudo -E bash install_valence.sh
#notes :Run this script as sudo user and not as root. #notes :Run this script as sudo user and not as root.
# This script is needed still valence is packaged in to .deb/.rpm # This script is needed still valence is packaged in to .deb/.rpm
#============================================================================== #==============================================================================
install_log=install_valence.log install_log=install_valence.log
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
CURR_USER="$(whoami)"
cd $DIR cd "$DIR"
echo "Current directory: $DIR" >> $install_log echo "Current directory: $DIR" >> $install_log
if [ `whoami` != 'root' ]; then if [ "$CURR_USER" != 'root' ]; then
echo "You must be root to install." echo "You must be root to install."
exit exit
fi fi
PYHOME="/usr/local/bin" PYHOME="/usr/local/bin"
@ -24,8 +25,8 @@ echo "Detected PYTHON HOME: $PYHOME" >> $install_log
# Copy the config files # Copy the config files
echo "Setting up valence config" >> $install_log echo "Setting up valence config" >> $install_log
sed s/\${CHUID}/`whoami`/ $DIR/doc/source/init/valence.conf > /tmp/valence.conf sed "s/\${CHUID}/$CURR_USER/" "$DIR"/doc/source/init/valence.conf > /tmp/valence.conf
#Use alternate sed delimiter because path will have / # Use alternate sed delimiter because path will have /
sed -i "s#PYHOME#$PYHOME#" /tmp/valence.conf sed -i "s#PYHOME#$PYHOME#" /tmp/valence.conf
mv /tmp/valence.conf /etc/init/valence.conf mv /tmp/valence.conf /etc/init/valence.conf
@ -33,14 +34,14 @@ mv /tmp/valence.conf /etc/init/valence.conf
if [ ! -d "/etc/valence" ]; then if [ ! -d "/etc/valence" ]; then
mkdir /etc/valence mkdir /etc/valence
fi fi
chown `whoami`:`whoami` /etc/valence chown "$CURR_USER":"$CURR_USER" /etc/valence
cp etc/valence/valence.conf.sample /etc/valence/valence.conf cp etc/valence/valence.conf.sample /etc/valence/valence.conf
# create log directory for valence if it doesn't exist # create log directory for valence if it doesn't exist
if [ ! -d "/var/log/valence" ]; then if [ ! -d "/var/log/valence" ]; then
mkdir /var/log/valence mkdir /var/log/valence
fi fi
chown `whoami`:`whoami` /var/log/valence chown "$CURR_USER":"$CURR_USER" /var/log/valence
echo "Installing dependencies from requirements.txt" >> $install_log echo "Installing dependencies from requirements.txt" >> $install_log
pip install -r requirements.txt pip install -r requirements.txt
@ -48,9 +49,9 @@ pip install -r requirements.txt
echo "Invoking setup.py" >> $install_log echo "Invoking setup.py" >> $install_log
python setup.py install python setup.py install
if [ $? -ne 0 ]; then if [ $? -ne 0 ]; then
echo "ERROR: setup.py failed. Please check $install_log for details. echo "ERROR: setup.py failed. Please check $install_log for details.
Please fix the error and retry." Please fix the error and retry."
exit exit
fi fi
echo "Installation Completed" echo "Installation Completed"