x/vmware-nsx
Code Issues Proposed changes

Remove workaround for bug #1219530

Browse Source 
Bug #1219530 has been fixed before Havana. We can remove this workaround.

Closes-Bug: #1307472
Change-Id: Ib0b1abf7d11627045be922f79aff6b80448ccbf4
This commit is contained in:
Yuriy Taraday 2014-04-07 19:54:46 +04:00
parent 346d674a10
commit 099eaf673b
2 changed files with 3 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
neutron/agent/linux/ovsdb_monitor.py
View File

@ -42,13 +42,6 @@ class OvsdbMonitor(async_process.AsyncProcess):
data = self._process.stdout.readline() data = self._process.stdout.readline()
if not data: if not data:
return return
#TODO(marun) The default root helper outputs exit errors to
# stdout due to bug #1219530. This check can be moved to
# _read_stderr once the error is correctly output to stderr.
if self.root_helper and self.root_helper in data:
self._stderr_lines.put(data)
LOG.error(_('Error received from ovsdb monitor: %s') % data)
else:
self._stdout_lines.put(data) self._stdout_lines.put(data)
LOG.debug(_('Output received from ovsdb monitor: %s') % data) LOG.debug(_('Output received from ovsdb monitor: %s') % data)
return data return data

7
neutron/tests/unit/agent/linux/test_ovsdb_monitor.py
View File

@ -43,13 +43,6 @@ class TestOvsdbMonitor(base.BaseTestCase):
result = self.read_output_queues_and_returns_result('stdout', '') result = self.read_output_queues_and_returns_result('stdout', '')
self.assertIsNone(result) self.assertIsNone(result)
def test__read_stdout_queues_root_wrapper_errors_to_stderr_output(self):
result = self.read_output_queues_and_returns_result('stdout',
self.root_helper)
self.assertIsNone(result)
self.assertEqual(self.monitor._stderr_lines.get_nowait(),
self.root_helper)
def test__read_stdout_queues_normal_output_to_stdout_queue(self): def test__read_stdout_queues_normal_output_to_stdout_queue(self):
output = 'foo' output = 'foo'
result = self.read_output_queues_and_returns_result('stdout', output) result = self.read_output_queues_and_returns_result('stdout', output)