x/vmware-nsx
Code Issues Proposed changes

[Tempest] spoofguard test fix from OpenStack plugin change

Browse Source 
Bugzilla bug 1894789 made a change to correct OpenStack port
update behavior, requiring security groups to be removed when
disabling port security.

Change-Id: Ida6fc3b06689eefae644b19fe4fe79ed5a174e8e
Bugs: 1906127(tempest fail), 1894789 (OpenStack)
This commit is contained in:
Christopher Chu Lin 2017-06-29 19:35:54 -04:00
parent b85f056932
commit 132046bd27
1 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
vmware_nsx_tempest/tests/nsxv/scenario/test_spoofguard_policy.py
View File

@ -184,7 +184,8 @@ class TestSpoofGuardFeature(TestSpoofGuardBasicOps):
net_id = self.green['network']['id'] net_id = self.green['network']['id']
name = 'disabled-port-security-port' name = 'disabled-port-security-port'
kwargs = {'name': name, 'network_id': net_id, kwargs = {'name': name, 'network_id': net_id,
'port_security_enabled': 'false'} 'port_security_enabled': 'false',
'security_groups': []}
# Create Port # Create Port
port = HELO.create_port(self, client=port_client, **kwargs) port = HELO.create_port(self, client=port_client, **kwargs)
port_id = port['id'] port_id = port['id']
@ -255,7 +256,8 @@ class TestSpoofGuardFeature(TestSpoofGuardBasicOps):
# Update vm1 port to disbale port security # Update vm1 port to disbale port security
port_client.update_port( port_client.update_port(
port_id=port1_id, port_id=port1_id,
port_security_enabled='false') port_security_enabled='false',
security_groups=[])
time.sleep(constants.NSX_BACKEND_TIME_INTERVAL) time.sleep(constants.NSX_BACKEND_TIME_INTERVAL)
self.compute_security_group_rules_client.\ self.compute_security_group_rules_client.\
delete_security_group_rule(self.green['rule_id']) delete_security_group_rule(self.green['rule_id'])
@ -313,7 +315,8 @@ class TestSpoofGuardFeature(TestSpoofGuardBasicOps):
# Update vm1 port to disbale port security # Update vm1 port to disbale port security
port_client.update_port( port_client.update_port(
port_id=port1_id, port_id=port1_id,
port_security_enabled='false') port_security_enabled='false',
security_groups=[])
items = self.vsm.get_excluded_vm_name_list() items = self.vsm.get_excluded_vm_name_list()
exclude_list = [item.encode('utf-8') for item in items] exclude_list = [item.encode('utf-8') for item in items]
for exclude_vm in exclude_list: for exclude_vm in exclude_list:
@ -323,7 +326,8 @@ class TestSpoofGuardFeature(TestSpoofGuardBasicOps):
# Update vm2 port to disable port security # Update vm2 port to disable port security
port_client.update_port( port_client.update_port(
port_id=port2_id, port_id=port2_id,
port_security_enabled='false') port_security_enabled='false',
security_groups=[])
items = self.vsm.get_excluded_vm_name_list() items = self.vsm.get_excluded_vm_name_list()
exclude_list = [item.encode('utf-8') for item in items] exclude_list = [item.encode('utf-8') for item in items]
# Check vm2 in exclude list or not # Check vm2 in exclude list or not
@ -334,7 +338,8 @@ class TestSpoofGuardFeature(TestSpoofGuardBasicOps):
# Update vm3 port to enable port security # Update vm3 port to enable port security
port_client.update_port( port_client.update_port(
port_id=port3_id, port_id=port3_id,
port_security_enabled='false') port_security_enabled='false',
security_groups=[])
items = self.vsm.get_excluded_vm_name_list() items = self.vsm.get_excluded_vm_name_list()
exclude_list = [item.encode('utf-8') for item in items] exclude_list = [item.encode('utf-8') for item in items]
# Check vm3 in exclude list or not # Check vm3 in exclude list or not
@ -361,7 +366,8 @@ class TestSpoofGuardFeature(TestSpoofGuardBasicOps):
# Update vm port to disable port security # Update vm port to disable port security
port_client.update_port( port_client.update_port(
port_id=port_id, port_id=port_id,
port_security_enabled='false') port_security_enabled='false',
security_groups=[])
vm_id = self.green['serv1']['id'] vm_id = self.green['serv1']['id']
# Check vm in exclude list or not # Check vm in exclude list or not
items = self.vsm.get_excluded_vm_name_list() items = self.vsm.get_excluded_vm_name_list()
@ -418,7 +424,8 @@ class TestSpoofGuardFeature(TestSpoofGuardBasicOps):
net_id = self.green['network']['id'] net_id = self.green['network']['id']
name = 'disabled-port-security-port1' name = 'disabled-port-security-port1'
kwargs = {'name': name, 'network_id': net_id, kwargs = {'name': name, 'network_id': net_id,
'port_security_enabled': 'false'} 'port_security_enabled': 'false',
'security_groups': []}
port1 = HELO.create_port(self, client=port_client, **kwargs) port1 = HELO.create_port(self, client=port_client, **kwargs)
port2 = HELO.create_port(self, client=port_client, **kwargs) port2 = HELO.create_port(self, client=port_client, **kwargs)
port1_id = port1['id'] port1_id = port1['id']