x/vmware-nsx
Code Issues Proposed changes

NSX|P: Fix loadbalancer deletion port handling

Browse Source 
When a loadbalancer is deleted, the relevant neutron port should
remove the device-id & owner.
But failure to update it should not fail the entire loadbalancer deletion,
as most of the resources were already deleted.

Change-Id: I8ad7fb75d4f65ab4e214efc933454ad02d1443c0
This commit is contained in:
asarfaty 2019-12-19 13:43:27 +02:00
parent eb93cd80f9
commit 189bb81edf
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
vmware_nsx/services/lbaas/nsx_p/implementation/loadbalancer_mgr.py
View File

@ -152,10 +152,15 @@ class EdgeLoadBalancerManagerFromDict(base_mgr.NsxpLoadbalancerBaseManager):
port = self.core_plugin.get_port(
context.elevated(), lb['vip_port_id'])
if port.get('device_owner') == lb_const.VMWARE_LB_VIP_OWNER:
self.core_plugin.update_port(
context.elevated(), lb['vip_port_id'],
{'port': {'device_id': '',
'device_owner': ''}})
try:
self.core_plugin.update_port(
context.elevated(), lb['vip_port_id'],
{'port': {'device_id': '',
'device_owner': ''}})
except Exception as e:
# Just log the error as all other resources were deleted
LOG.error("Failed to update neutron port %s devices upon "
"loadbalancer deletion: %s", lb['vip_port_id'], e)
completor(success=True)