x/vmware-nsx
Code Issues Proposed changes

Send only one agent notification on port update

Browse Source 
This patch removes the other redundant notification sent in the same
routine to notify whether a security group changed.

Closes-Bug: #1254924
Partial Blueprint neutron-tempest-parallel

Change-Id: I5bad015decdc197c3fa9b58c680564380d513bc4
This commit is contained in:
Salvatore Orlando 2013-11-25 16:25:43 -08:00
parent 5d1121276b
commit 18fc9f0f94
2 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
neutron/db/securitygroups_rpc_base.py
View File

@ -98,8 +98,6 @@ class SecurityGroupServerRpcMixin(sg_db.SecurityGroupDbMixin):
not utils.compare_elements( not utils.compare_elements(
original_port.get(ext_sg.SECURITYGROUPS), original_port.get(ext_sg.SECURITYGROUPS),
updated_port.get(ext_sg.SECURITYGROUPS))): updated_port.get(ext_sg.SECURITYGROUPS))):
self.notify_security_groups_member_updated(
context, updated_port)
need_notify = True need_notify = True
return need_notify return need_notify

4
neutron/tests/unit/test_security_groups_rpc.py
View File

@ -1442,9 +1442,7 @@ class SGNotificationTestMixin():
self._delete('ports', port['port']['id']) self._delete('ports', port['port']['id'])
self.notifier.assert_has_calls( self.notifier.assert_has_calls(
[call.security_groups_member_updated( [call.security_groups_member_updated(
mock.ANY, [mock.ANY]), mock.ANY, [mock.ANY])])
call.security_groups_member_updated(
mock.ANY, [security_group_id])])
class TestSecurityGroupAgentWithOVSIptables( class TestSecurityGroupAgentWithOVSIptables(