x/vmware-nsx
Code Issues Proposed changes

Merge "Switch run-time import to using importutils.import_module"

Browse Source
This commit is contained in:
Jenkins 2014-11-19 11:49:20 +00:00 committed by Gerrit Code Review
commit 3b91568010
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.pylintrc
View File

@ -73,7 +73,6 @@ disable=
# "R" Refactor recommendations # "R" Refactor recommendations
abstract-class-little-used, abstract-class-little-used,
abstract-class-not-used, abstract-class-not-used,
cyclic-import,
duplicate-code, duplicate-code,
interface-not-implemented, interface-not-implemented,
no-self-use, no-self-use,

4
neutron/policy.py
View File

@ -299,9 +299,9 @@ class OwnerCheck(policy.Check):
# resource is handled by the core plugin. It might be worth # resource is handled by the core plugin. It might be worth
# having a way to map resources to plugins so to make this # having a way to map resources to plugins so to make this
# check more general # check more general
# FIXME(ihrachys): if import is put in global, circular # NOTE(ihrachys): if import is put in global, circular
# import failure occurs # import failure occurs
from neutron import manager manager = importutils.import_module('neutron.manager')
f = getattr(manager.NeutronManager.get_instance().plugin, f = getattr(manager.NeutronManager.get_instance().plugin,
'get_%s' % parent_res) 'get_%s' % parent_res)
# f *must* exist, if not found it is better to let neutron # f *must* exist, if not found it is better to let neutron