x/vmware-nsx
Code Issues Proposed changes

NSX|V: Fix use case with no FWaaS for a router

Browse Source 
In case FWaaS is enabled, but a router is not assigned to and firewall,
the Allow-external traffic rule should be added to the edge firewall, just like
when FWaaS is disabled.

Change-Id: Id59b467c530ac0aa6070539358481e41be4623d6
This commit is contained in:
Adit Sarfaty 2017-05-15 09:40:28 +03:00
parent 2cdab3af8c
commit 4b05c62e78
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
vmware_nsx/services/fwaas/nsx_v/fwaas_callbacks.py
View File

@ -98,6 +98,10 @@ class NsxvFwaasCallbacks(firewall_l3_agent.L3WithFWaaS):
# Do not add firewall rules on the tlr router. # Do not add firewall rules on the tlr router.
return False return False
if not self._get_router_firewall_id(ctx_elevated, router_id):
# No FWaas Firewall was assigned to this router
return False
return True return True
def get_fwaas_rules_for_router(self, context, router_id): def get_fwaas_rules_for_router(self, context, router_id):