x/vmware-nsx
Code Issues Proposed changes

NSX|V: validate result before return IP

Browse Source 
Ensures that ports exist before reading the port 'ip_address'.

Change-Id: I8fd02a61a9f755437e4fb8b93a2d55728d53aa86
Closes-bug: #1576516
This commit is contained in:
Gary Kotton 2016-04-28 22:30:16 -07:00
parent e94d0eb6fa
commit 4d9ce89584
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
vmware_nsx/plugins/nsx_v/md_proxy.py
View File

@ -196,11 +196,14 @@ class NsxVMetadataProxyHandler:
return internal_net, internal_subnet
def _get_edge_internal_ip(self, rtr_id):
filters = {
'network_id': [self.internal_net],
'device_id': [rtr_id]}
ports = self.nsxv_plugin.get_ports(self.context, filters=filters)
filters = {
'network_id': [self.internal_net],
'device_id': [rtr_id]}
ports = self.nsxv_plugin.get_ports(self.context, filters=filters)
if ports:
return ports[0]['fixed_ips'][0]['ip_address']
else:
LOG.error(_LE("No port found for metadata for %s"), rtr_id)
def _get_edge_rtr_id_by_ext_ip(self, edge_ip):
rtr_list = nsxv_db.get_nsxv_internal_edge(