From 189bb81edf36297a70e5a86989c65e0cf2e2701e Mon Sep 17 00:00:00 2001 From: asarfaty Date: Thu, 19 Dec 2019 13:43:27 +0200 Subject: [PATCH] NSX|P: Fix loadbalancer deletion port handling When a loadbalancer is deleted, the relevant neutron port should remove the device-id & owner. But failure to update it should not fail the entire loadbalancer deletion, as most of the resources were already deleted. Change-Id: I8ad7fb75d4f65ab4e214efc933454ad02d1443c0 --- .../lbaas/nsx_p/implementation/loadbalancer_mgr.py | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/vmware_nsx/services/lbaas/nsx_p/implementation/loadbalancer_mgr.py b/vmware_nsx/services/lbaas/nsx_p/implementation/loadbalancer_mgr.py index 2066a3c99d..843747b9cb 100644 --- a/vmware_nsx/services/lbaas/nsx_p/implementation/loadbalancer_mgr.py +++ b/vmware_nsx/services/lbaas/nsx_p/implementation/loadbalancer_mgr.py @@ -152,10 +152,15 @@ class EdgeLoadBalancerManagerFromDict(base_mgr.NsxpLoadbalancerBaseManager): port = self.core_plugin.get_port( context.elevated(), lb['vip_port_id']) if port.get('device_owner') == lb_const.VMWARE_LB_VIP_OWNER: - self.core_plugin.update_port( - context.elevated(), lb['vip_port_id'], - {'port': {'device_id': '', - 'device_owner': ''}}) + try: + self.core_plugin.update_port( + context.elevated(), lb['vip_port_id'], + {'port': {'device_id': '', + 'device_owner': ''}}) + except Exception as e: + # Just log the error as all other resources were deleted + LOG.error("Failed to update neutron port %s devices upon " + "loadbalancer deletion: %s", lb['vip_port_id'], e) completor(success=True)