x/vmware-nsx
Code Issues Proposed changes

Merge "remove incorrect mock assert_called in unit tests"

Browse Source
This commit is contained in:
Jenkins 2012-09-08 20:37:19 +00:00 committed by Gerrit Code Review
commit 6b24e1e64d
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
quantum/tests/unit/test_dhcp_agent.py
View File

@ -375,7 +375,7 @@ class TestDhcpPluginApiProxy(unittest.TestCase):
def test_get_active_networks(self):
self.proxy.get_active_networks()
self.call.assert_called()
self.assertTrue(self.call.called)
self.make_msg.assert_called_once_with('get_active_networks',
host='foo')
@ -383,7 +383,7 @@ class TestDhcpPluginApiProxy(unittest.TestCase):
self.call.return_value = dict(a=1)
retval = self.proxy.get_network_info('netid')
self.assertEqual(retval.a, 1)
self.call.assert_called()
self.assertTrue(self.call.called)
self.make_msg.assert_called_once_with('get_network_info',
network_id='netid',
host='foo')
@ -392,7 +392,7 @@ class TestDhcpPluginApiProxy(unittest.TestCase):
self.call.return_value = dict(a=1)
retval = self.proxy.get_dhcp_port('netid', 'devid')
self.assertEqual(retval.a, 1)
self.call.assert_called()
self.assertTrue(self.call.called)
self.make_msg.assert_called_once_with('get_dhcp_port',
network_id='netid',
device_id='devid',
@ -400,7 +400,7 @@ class TestDhcpPluginApiProxy(unittest.TestCase):
def test_release_dhcp_port(self):
self.proxy.release_dhcp_port('netid', 'devid')
self.call.assert_called()
self.assertTrue(self.call.called)
self.make_msg.assert_called_once_with('release_dhcp_port',
network_id='netid',
device_id='devid',
@ -408,7 +408,7 @@ class TestDhcpPluginApiProxy(unittest.TestCase):
def test_release_port_fixed_ip(self):
self.proxy.release_port_fixed_ip('netid', 'devid', 'subid')
self.call.assert_called()
self.assertTrue(self.call.called)
self.make_msg.assert_called_once_with('release_port_fixed_ip',
network_id='netid',
subnet_id='subid',
@ -418,7 +418,7 @@ class TestDhcpPluginApiProxy(unittest.TestCase):
def test_update_lease_expiration(self):
with mock.patch.object(self.proxy, 'cast') as mock_cast:
self.proxy.update_lease_expiration('netid', 'ipaddr', 1)
mock_cast.assert_called()
self.assertTrue(mock_cast.called)
self.make_msg.assert_called_once_with('update_lease_expiration',
network_id='netid',
ip_address='ipaddr',