From 6e3c011fc32d62789afc9ea55425ec3614856c5d Mon Sep 17 00:00:00 2001 From: Christian Berendt Date: Fri, 4 Jul 2014 13:12:26 +0200 Subject: [PATCH] Raise NotImplementedError instead of NotImplemented NotImplementedError is the name of the exception (https://docs.python.org/2/library/exceptions.html). NotImplemented is the name of a constant (https://docs.python.org/2/library/constants.html). It makes no sense to raise a constant. The exception should be raised instead. Change-Id: I4969e26eb7b46f008ea3c8bd0093490c425f7069 Closes-Bug: #1339855 --- neutron/agent/linux/polling.py | 2 +- neutron/tests/unit/agent/linux/test_polling.py | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/neutron/agent/linux/polling.py b/neutron/agent/linux/polling.py index 23168085fd..9e2163ac28 100644 --- a/neutron/agent/linux/polling.py +++ b/neutron/agent/linux/polling.py @@ -52,7 +52,7 @@ class BasePollingManager(object): self._polling_completed = True def _is_polling_required(self): - raise NotImplemented + raise NotImplementedError() @property def is_polling_required(self): diff --git a/neutron/tests/unit/agent/linux/test_polling.py b/neutron/tests/unit/agent/linux/test_polling.py index 90b48e0bc9..ba18a86483 100644 --- a/neutron/tests/unit/agent/linux/test_polling.py +++ b/neutron/tests/unit/agent/linux/test_polling.py @@ -43,6 +43,9 @@ class TestBasePollingManager(base.BaseTestCase): super(TestBasePollingManager, self).setUp() self.pm = polling.BasePollingManager() + def test__is_polling_required_should_not_be_implemented(self): + self.assertRaises(NotImplementedError, self.pm._is_polling_required) + def test_force_polling_sets_interval_attribute(self): self.assertFalse(self.pm._force_polling) self.pm.force_polling()