x/vmware-nsx
Code Issues Proposed changes

Enable polling minimization

Browse Source 
In some cases the OVS agent might end up wiring a port for a VM
several seconds after the VM has booted. As a result, there is a
risk that the VM won't receive an IP address from DHCP in time.

This patch changes the default value for agent.minimize_polling to
True. This change should reduce the time needed for configuring
an interface on br-int consistently.

Change-Id: I009f606fd34a132376f1d50f8ccda9d35d064bfa
Related-bug: 1224001
This commit is contained in:
Salvatore Orlando 2013-11-19 09:32:35 -08:00 committed by Terry Wilson
parent 14950e492a
commit 70096ae4e7
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
etc/neutron/plugins/openvswitch/ovs_neutron_plugin.ini
View File

@ -88,7 +88,7 @@
# polling_interval = 2 # polling_interval = 2
# Minimize polling by monitoring ovsdb for interface changes # Minimize polling by monitoring ovsdb for interface changes
# minimize_polling = False # minimize_polling = True
# When minimize_polling = True, the number of seconds to wait before # When minimize_polling = True, the number of seconds to wait before
# respawning the ovsdb monitor after losing communication with it # respawning the ovsdb monitor after losing communication with it

2
neutron/plugins/openvswitch/common/config.py
View File

@ -63,7 +63,7 @@ agent_opts = [
help=_("The number of seconds the agent will wait between " help=_("The number of seconds the agent will wait between "
"polling for local device changes.")), "polling for local device changes.")),
cfg.BoolOpt('minimize_polling', cfg.BoolOpt('minimize_polling',
default=False, default=True,
help=_("Minimize polling by monitoring ovsdb for interface " help=_("Minimize polling by monitoring ovsdb for interface "
"changes.")), "changes.")),
cfg.IntOpt('ovsdb_monitor_respawn_interval', cfg.IntOpt('ovsdb_monitor_respawn_interval',

2
neutron/tests/unit/openvswitch/test_ovs_neutron_agent.py
View File

@ -588,7 +588,7 @@ class TestOvsNeutronAgent(base.BaseTestCase):
'neutron.agent.linux.polling.get_polling_manager') as mock_get_pm: 'neutron.agent.linux.polling.get_polling_manager') as mock_get_pm:
with mock.patch.object(self.agent, 'rpc_loop') as mock_loop: with mock.patch.object(self.agent, 'rpc_loop') as mock_loop:
self.agent.daemon_loop() self.agent.daemon_loop()
mock_get_pm.assert_called_with(False, 'sudo', mock_get_pm.assert_called_with(True, 'sudo',
constants.DEFAULT_OVSDBMON_RESPAWN) constants.DEFAULT_OVSDBMON_RESPAWN)
mock_loop.called_once() mock_loop.called_once()