x/vmware-nsx
Code Issues Proposed changes

NSX|V3: Support new icmp codes and types

Browse Source 
This patch is to verify and fix support for
NSX ver 2.4, which involves new icmp list that
is more strict.

Change-Id: I91ef1bdc8287ea85281c543353774d6e3cac5ac2
Signed-off-by: Michal Kelner Mishali <mkelnermishal@vmware.com>
This commit is contained in:
Michal Kelner Mishali 2018-08-13 09:20:42 +03:00 committed by Adit Sarfaty
parent 906e8f74b1
commit 7630ecb8f2
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
vmware_nsx/tests/unit/extensions/test_securitygroup.py
View File

@ -69,8 +69,8 @@ class TestSecurityGroups(test_nsxv3.NsxV3PluginTestCaseMixin,
# port_range_min (ICMP type) is greater than port_range_max # port_range_min (ICMP type) is greater than port_range_max
# (ICMP code) in order to confirm min <= max port check is # (ICMP code) in order to confirm min <= max port check is
# not called for ICMP. # not called for ICMP.
port_range_min = 5 port_range_min = 14
port_range_max = 1 port_range_max = None
keys = [('remote_ip_prefix', remote_ip_prefix), keys = [('remote_ip_prefix', remote_ip_prefix),
('security_group_id', security_group_id), ('security_group_id', security_group_id),
('direction', direction), ('direction', direction),
@ -106,8 +106,8 @@ class TestSecurityGroupsNoDynamicCriteria(test_nsxv3.NsxV3PluginTestCaseMixin,
# port_range_min (ICMP type) is greater than port_range_max # port_range_min (ICMP type) is greater than port_range_max
# (ICMP code) in order to confirm min <= max port check is # (ICMP code) in order to confirm min <= max port check is
# not called for ICMP. # not called for ICMP.
port_range_min = 5 port_range_min = 14
port_range_max = 1 port_range_max = None
keys = [('remote_ip_prefix', remote_ip_prefix), keys = [('remote_ip_prefix', remote_ip_prefix),
('security_group_id', security_group_id), ('security_group_id', security_group_id),
('direction', direction), ('direction', direction),