x/vmware-nsx
Code Issues Proposed changes

Utilize assertIsInstance

Browse Source 
Using assertTrue and the 'isinstance' function to test
if an object is in an instance of some class is too python2.4.
Our unit testing framework supports assertIsInstance which was created
for these types of tests. Let's use assertIsInstance for these tests.

Fixes bug #1230028

Change-Id: Ia03c9f19a1c5e2aef3a6fe530515bd26339a7975
This commit is contained in:
Zhongyue Luo 2013-09-06 16:00:59 +08:00 committed by Gerrit Code Review
parent 512bdfa713
commit 795e731f9b
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
neutron/tests/unit/nicira/test_nvp_api_request_eventlet.py
View File

@ -158,7 +158,7 @@ class NvpApiRequestEventletTest(base.BaseTestCase):
self.req._issue_request() self.req._issue_request()
LOG.info('request_error: %s' % self.req._request_error) LOG.info('request_error: %s' % self.req._request_error)
self.assertTrue(isinstance(self.req._request_error, Exception)) self.assertIsInstance(self.req._request_error, Exception)
self.assertTrue(self.client.acquire_connection.called) self.assertTrue(self.client.acquire_connection.called)
def test_issue_request_handle_none_sock(self): def test_issue_request_handle_none_sock(self):

4
neutron/tests/unit/test_linux_interface.py
View File

@ -358,9 +358,7 @@ class TestMetaInterfaceDriver(TestBase):
def test_get_driver_by_network_id(self): def test_get_driver_by_network_id(self):
meta_interface = interface.MetaInterfaceDriver(self.conf) meta_interface = interface.MetaInterfaceDriver(self.conf)
driver = meta_interface._get_driver_by_network_id('test') driver = meta_interface._get_driver_by_network_id('test')
self.assertTrue(isinstance( self.assertIsInstance(driver, interface.OVSInterfaceDriver)
driver,
interface.OVSInterfaceDriver))
def test_set_device_plugin_tag(self): def test_set_device_plugin_tag(self):
meta_interface = interface.MetaInterfaceDriver(self.conf) meta_interface = interface.MetaInterfaceDriver(self.conf)