x/vmware-nsx
Code Issues Proposed changes

NSX|P Fix router interface removal

Browse Source 
And enable the CI test that was blocked with this issue

Depends-on: Ib0ab3baacc65437aa1d822a133bdec2ebf566bd5
Change-Id: I96c6eee726c7da3fa63b7c0da6141a1285581c12
This commit is contained in:
Adit Sarfaty 2018-12-17 13:28:31 +02:00
parent e5649bc23c
commit 8374f93bbc
2 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
devstack/nsx_p/devstackgaterc
View File

@ -39,9 +39,6 @@ r="$r|(?:tempest\.api\.network\.admin\.test_external_network_extension\.External
# Some ICMP types are not supported by the NSX backend # Some ICMP types are not supported by the NSX backend
r="$r|(?:tempest\.api\.network\.test_security_groups\.SecGroupTest\.test_create_security_group_rule_with_icmp_type_code.*)" r="$r|(?:tempest\.api\.network\.test_security_groups\.SecGroupTest\.test_create_security_group_rule_with_icmp_type_code.*)"
# TODO(asarfaty): Make this test pass
r="$r|(?:tempest\.api\.network\.test_routers_negative\.RoutersNegativeTest\.test_router_remove_interface_in_use_returns_409.*)"
# End list of exclusions. # End list of exclusions.
r="$r)" r="$r)"

9
vmware_nsx/plugins/nsx_p/plugin.py
View File

@ -1233,15 +1233,8 @@ class NsxPolicyPlugin(agentschedulers_db.AZDhcpAgentSchedulerDbMixin,
# Remove the tier1 router from this segment on the nSX # Remove the tier1 router from this segment on the nSX
try: try:
#TODO(asarfaty): adding the segment name even though it was not
# changed because otherwise the NSX will set it to default.
# This code should be removed once NSX supports it.
net = self._get_network(context, network_id)
net_name = utils.get_name_and_uuid(
net['name'] or 'network', network_id)
segment_id = self._get_network_nsx_segment_id(context, network_id) segment_id = self._get_network_nsx_segment_id(context, network_id)
self.nsxpolicy.segment.update(segment_id, name=net_name, self.nsxpolicy.segment.remove_connectivity_and_subnets(segment_id)
tier1_id=None)
# try to delete the SNAT/NO_DNAT rules of this subnet # try to delete the SNAT/NO_DNAT rules of this subnet
router_db = self._get_router(context, router_id) router_db = self._get_router(context, router_id)