x/vmware-nsx
Code Issues Proposed changes

NSX|V3: restrict allowed-address-pairs on LB port

Browse Source 
allowed-address-pairs is not supported on LB port

Change-Id: I7588a14b94886e25354a900c4fc0b77cf5e03154
Signed-off-by: Michal Kelner Mishali <mkelnermishal@vmware.com>
This commit is contained in:
Michal Kelner Mishali 2018-09-02 11:08:44 +03:00
parent 3be8af0c37
commit 8f39db15b8
2 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
vmware_nsx/plugins/common/plugin.py
View File

@ -481,6 +481,12 @@ class NsxPluginBase(db_base_plugin_v2.NeutronDbPluginV2,
def _assert_on_device_owner_change(self, port_data, orig_dev_own): def _assert_on_device_owner_change(self, port_data, orig_dev_own):
"""Prevent illegal device owner modifications """Prevent illegal device owner modifications
""" """
if orig_dev_own == constants.DEVICE_OWNER_LOADBALANCERV2:
if port_data['allowed_address_pairs']:
msg = _('Loadbalancer port can not be updated '
'with address pairs')
raise n_exc.InvalidInput(error_message=msg)
if 'device_owner' not in port_data: if 'device_owner' not in port_data:
return return
new_dev_own = port_data['device_owner'] new_dev_own = port_data['device_owner']

17
vmware_nsx/tests/unit/nsx_v3/test_plugin.py
View File

@ -980,6 +980,23 @@ class TestPortsV2(test_plugin.TestPortsV2, NsxV3PluginTestCaseMixin,
self.assertEqual(exc.HTTPBadRequest.code, self.assertEqual(exc.HTTPBadRequest.code,
res.status_int) res.status_int)
def test_fail_update_lb_port_with_allowed_address_pairs(self):
with self.network() as network:
data = {'port': {
'network_id': network['network']['id'],
'tenant_id': self._tenant_id,
'name': 'pair_port',
'admin_state_up': True,
'device_id': 'fake_device',
'device_owner': constants.DEVICE_OWNER_LOADBALANCERV2,
'fixed_ips': []}
}
port = self.plugin.create_port(self.ctx, data)
data['port']['allowed_address_pairs'] = '10.0.0.1'
self.assertRaises(
n_exc.InvalidInput,
self.plugin.update_port, self.ctx, port['id'], data)
def test_create_port_with_qos(self): def test_create_port_with_qos(self):
with self.network() as network: with self.network() as network:
policy_id = uuidutils.generate_uuid() policy_id = uuidutils.generate_uuid()