x/vmware-nsx
Code Issues Proposed changes

Cisco: unsupported format character in log format

Browse Source 
CiscoCfgAgent.hosting_devices_removed() contains an error in the
format string used to log errors:

    LOG.error(_LE("Invalid payload format for received RPC message "
		"`hosting_devices_removed`. Error is %{error}s. "
		"Payload is %(payload)s"),
	      {'error': e, 'payload': payload})

"%{error}s" should be "%(error)s"

The existing version raises "ValueError: unsupported format character
'{' (0x7b)" when invoked.

(found via pylint)

Change-Id: Ic5e9db2a19aa7652cbbd1ee04d7e02914e8d0093
Closes-Bug: #1403304
This commit is contained in:
Angus Lees 2014-12-17 15:44:12 +11:00
parent c3e19729ee
commit 99331b97ea
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
neutron/plugins/cisco/cfg_agent/cfg_agent.py
View File

@ -228,7 +228,7 @@ class CiscoCfgAgent(manager.Manager):
self.process_services(removed_devices_info=payload) self.process_services(removed_devices_info=payload)
except KeyError as e: except KeyError as e:
LOG.error(_LE("Invalid payload format for received RPC message " LOG.error(_LE("Invalid payload format for received RPC message "
"`hosting_devices_removed`. Error is %{error}s. " "`hosting_devices_removed`. Error is %(error)s. "
"Payload is %(payload)s"), "Payload is %(payload)s"),
{'error': e, 'payload': payload}) {'error': e, 'payload': payload})