From a9d479ab6181b3fcffe24cc43450355a72af2dd0 Mon Sep 17 00:00:00 2001 From: Shih-Hao Li Date: Tue, 8 Dec 2015 11:18:47 -0800 Subject: [PATCH] Skip updating logical port when removing router interface During the process of removing a router interface, the plugin sends three API requests to the backend: (1) DELETE logical router port, (2) PUT logical port, (3) DELETE logical port. The PUT request is used to remove security group bindings and change admin state to DOWN on the corresponding logical port. Since a DELETE request will be sent right after the PUT request, the PUT request can be skipped if the backend will auto-remove security group bindings during a DELETE operation. Change-Id: I73f563a71562a54f75a94e575d4f5248d973e78f --- vmware_nsx/plugins/nsx_v3/plugin.py | 7 ------- 1 file changed, 7 deletions(-) diff --git a/vmware_nsx/plugins/nsx_v3/plugin.py b/vmware_nsx/plugins/nsx_v3/plugin.py index 84eb65bdbb..312b36a0c4 100644 --- a/vmware_nsx/plugins/nsx_v3/plugin.py +++ b/vmware_nsx/plugins/nsx_v3/plugin.py @@ -691,13 +691,6 @@ class NsxV3Plugin(addr_pair_db.AllowedAddressPairsMixin, if not self._network_is_external(context, port['network_id']): _net_id, nsx_port_id = nsx_db.get_nsx_switch_and_port_id( context.session, port_id) - # Update port to remove security group bindings from the - # backend and change it's admin state to DOWN - updated_port = {'port': {ext_sg.SECURITYGROUPS: [], - 'admin_state_up': False}} - self._update_port_on_backend(context, nsx_port_id, - port, updated_port, - [], []) self._port_client.delete(nsx_port_id) self.disassociate_floatingips(context, port_id) ret_val = super(NsxV3Plugin, self).delete_port(context, port_id)