x/vmware-nsx
Code Issues Proposed changes

NSX: ensure dhcp port is setup on metadata network

Browse Source 
Change in scheduling behavior caused a regression
where the dhcp port is no longer provisioned on
the (admin) metadata network created when a subnet
is uplinked to a router.

This change recovers the past behavior and extend UT
coverage to avoid further regression.

Closes-bug: #1304127

Change-Id: I8420203f68a43368f3784adb0c4cbbe55f048662
This commit is contained in:
armando-migliaccio 2014-04-08 08:43:00 -07:00
parent f6515fb40d
commit aa7a4f297d
2 changed files with 37 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
neutron/plugins/vmware/dhcp_meta/rpc.py
View File

@ -164,6 +164,8 @@ def _create_metadata_access_network(plugin, context, router_id):
meta_net = plugin.create_network(context, meta_net = plugin.create_network(context,
{'network': net_data}) {'network': net_data})
greenthread.sleep(0) # yield greenthread.sleep(0) # yield
plugin.schedule_network(context, meta_net)
greenthread.sleep(0) # yield
# From this point on there will be resources to garbage-collect # From this point on there will be resources to garbage-collect
# in case of failures # in case of failures
meta_sub = None meta_sub = None
@ -187,6 +189,8 @@ def _create_metadata_access_network(plugin, context, router_id):
plugin.add_router_interface(context, router_id, plugin.add_router_interface(context, router_id,
{'subnet_id': meta_sub['id']}) {'subnet_id': meta_sub['id']})
greenthread.sleep(0) # yield greenthread.sleep(0) # yield
# Tell to start the metadata agent proxy, only if we had success
_notify_rpc_agent(context, {'subnet': meta_sub}, 'subnet.create.end')
except (ntn_exc.NeutronException, except (ntn_exc.NeutronException,
nsx_exc.NsxPluginException, nsx_exc.NsxPluginException,
api_exc.NsxApiException): api_exc.NsxApiException):
@ -194,9 +198,6 @@ def _create_metadata_access_network(plugin, context, router_id):
# as it will be removed with the network # as it will be removed with the network
plugin.delete_network(context, meta_net['id']) plugin.delete_network(context, meta_net['id'])
# Tell to start the metadata agent proxy
_notify_rpc_agent(context, {'network': meta_net}, 'network.create.end')
def _destroy_metadata_access_network(plugin, context, router_id, ports): def _destroy_metadata_access_network(plugin, context, router_id, ports):
if not ports: if not ports:

52
neutron/tests/unit/vmware/test_nsx_plugin.py
View File

@ -767,25 +767,39 @@ class TestL3NatTestCase(L3NatTest,
def test_metadatata_network_created_with_router_interface_add(self): def test_metadatata_network_created_with_router_interface_add(self):
self._metadata_setup() self._metadata_setup()
with self.router() as r: with mock.patch.object(self._plugin_class, 'schedule_network') as f:
with self.subnet() as s: with self.router() as r:
self._router_interface_action('add', with self.subnet() as s:
r['router']['id'], self._router_interface_action('add',
s['subnet']['id'], r['router']['id'],
None) s['subnet']['id'],
r_ports = self._list('ports')['ports'] None)
self.assertEqual(len(r_ports), 2) r_ports = self._list('ports')['ports']
ips = [] self.assertEqual(len(r_ports), 2)
for port in r_ports: ips = []
ips.extend([netaddr.IPAddress(fixed_ip['ip_address']) for port in r_ports:
for fixed_ip in port['fixed_ips']]) ips.extend([netaddr.IPAddress(fixed_ip['ip_address'])
meta_cidr = netaddr.IPNetwork('169.254.0.0/16') for fixed_ip in port['fixed_ips']])
self.assertTrue(any([ip in meta_cidr for ip in ips])) meta_cidr = netaddr.IPNetwork('169.254.0.0/16')
# Needed to avoid 409 self.assertTrue(any([ip in meta_cidr for ip in ips]))
self._router_interface_action('remove', # Needed to avoid 409
r['router']['id'], self._router_interface_action('remove',
s['subnet']['id'], r['router']['id'],
None) s['subnet']['id'],
None)
# Verify that the metadata network gets scheduled first, so that
# an active dhcp agent can pick it up
expected_meta_net = {
'status': 'ACTIVE',
'subnets': [],
'name': 'meta-%s' % r['router']['id'],
'admin_state_up': True,
'tenant_id': '',
'port_security_enabled': False,
'shared': False,
'id': mock.ANY
}
f.assert_called_once_with(mock.ANY, expected_meta_net)
self._metadata_teardown() self._metadata_teardown()
def test_metadata_network_create_rollback_on_create_subnet_failure(self): def test_metadata_network_create_rollback_on_create_subnet_failure(self):