x/vmware-nsx
Code Issues Proposed changes

Need to pass port['port'] to _get_tenant_id_for_create()

Browse Source 
This change set I9ac44a8e moved this logic out of the transaction
which caused this bug. Unit tests did not catch this because
this error is caused on NVP since the tenant_id is passed in as a tag
and this change resulted in the tenant_id becoming None which is not
an allowed tag value. Will improve error handling and edge cases like
this to fake_nvpapiclient in different commit.

Change-Id: Ib0eaab1f389de98b335f58e9215981adbbf9e2ef
This commit is contained in:
Aaron Rosen 2013-02-17 18:49:40 -08:00
parent 805ee2a763
commit b77246b844
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
quantum/plugins/nicira/nicira_nvp_plugin/QuantumPlugin.py
View File

@ -1161,7 +1161,7 @@ class NvpPluginV2(db_base_plugin_v2.QuantumDbPluginV2,
if attr.is_attr_set(port['port'].get(psec.PORTSECURITY)): if attr.is_attr_set(port['port'].get(psec.PORTSECURITY)):
self._enforce_set_auth(context, port, self._enforce_set_auth(context, port,
self.port_security_enabled_update) self.port_security_enabled_update)
tenant_id = self._get_tenant_id_for_create(context, port) tenant_id = self._get_tenant_id_for_create(context, port['port'])
delete_security_groups = self._check_update_deletes_security_groups( delete_security_groups = self._check_update_deletes_security_groups(
port) port)
has_security_groups = self._check_update_has_security_groups(port) has_security_groups = self._check_update_has_security_groups(port)