x/vmware-nsx
Code Issues Proposed changes

NSX|V Do not allow router with lbaas migration

Browse Source 
In case a loadbalancer is on an exclusive router edge, do not allow
changing the router type to shared.

Change-Id: Idc36a0bb096302274ea182dd9f0535627bc28cfa
This commit is contained in:
Adit Sarfaty 2018-04-26 13:31:49 +03:00
parent 27d7f53f10
commit ce92804ead
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
vmware_nsx/plugins/nsx_v/plugin.py
View File

@ -3263,6 +3263,16 @@ class NsxVPluginV2(addr_pair_db.AllowedAddressPairsMixin,
len(router['routes']) > 0):
raise n_exc.InvalidInput(error_message=err_msg)
# shared router cannot be attached to a loadbalancer
edge_id = self._get_edge_id_by_rtr_id(context, router_id)
if edge_id:
lb_bind = nsxv_db.get_nsxv_lbaas_loadbalancer_binding_by_edge(
context.session, edge_id)
if lb_bind:
err_msg = _('Unable to create a shared router with a load '
'balancer')
raise n_exc.InvalidInput(error_message=err_msg)
def update_router(self, context, router_id, router):
with locking.LockManager.get_lock('router-%s' % router_id):
return self._safe_update_router(context, router_id, router)