x/vmware-nsx
Code Issues Proposed changes

Optimize floating IP status update

Browse Source 
Hopefully also avoid tracebacks due to nested transactions
being rolled back

Change-Id: I1e74fb8d90de09b53d330f499b93073f19a5b9bf
Closes-Bug: #1290549
This commit is contained in:
Salvatore Orlando 2014-03-10 13:42:58 -07:00 committed by Aaron Rosen
parent 4d257ca02b
commit d057b03391
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
neutron/db/l3_db.py
View File

@ -677,10 +677,9 @@ class L3_NAT_db_mixin(l3.RouterPluginBase):
def update_floatingip_status(self, context, floatingip_id, status):
"""Update operational status for floating IP in neutron DB."""
# TODO(salv-orlando): Optimize avoiding fetch before update
with context.session.begin(subtransactions=True):
floatingip_db = self._get_floatingip(context, floatingip_id)
floatingip_db['status'] = status
fip_query = self._model_query(context, FloatingIP).filter(
FloatingIP.id == floatingip_id)
fip_query.update({'status': status}, synchronize_session=False)
def delete_floatingip(self, context, id):
floatingip = self._get_floatingip(context, id)