x/vmware-nsx
Code Issues Proposed changes

Ensure that ListOpt configuration variables are set

Browse Source 
Ensure that the default value is []. If no default is set then the
CFG module assigns the value None. There are some edge cases where
a configuration setting has not been set and there is random failure.

Ideally we should validate the configurations at boot. But that is
another patch set.

Change-Id: I402590f8f0dc86e485716fb2f0fa63262dda96c7
This commit is contained in:
Gary Kotton 2016-06-14 05:41:03 -07:00
parent 0f441265ea
commit d06218acbe
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
vmware_nsx/common/config.py
View File

@ -184,6 +184,7 @@ connection_opts = [
help=_('Maximum number of times a redirect response '
'should be followed')),
cfg.ListOpt('nsx_controllers',
default=[],
deprecated_name='nvp_controllers',
help=_('Comma-separated list of NSX controller '
'endpoints (<ip>:<port>). When port is omitted, '
@ -249,6 +250,7 @@ nsx_v3_opts = [
secret=True,
help=_('Password for the NSX manager')),
cfg.ListOpt('nsx_api_managers',
default=[],
deprecated_name='nsx_manager',
help=_("IP address of one or more NSX managers separated "
"by commas. The IP address should be of the form:\n"
@ -446,6 +448,7 @@ nsxv_opts = [
help=_('(Optional) Portgroup MoRef ID for metadata proxy '
'management network')),
cfg.ListOpt('mgt_net_proxy_ips',
default=[],
help=_('(Optional) Comma separated list of management network '
'IP addresses for metadata proxy.')),
cfg.StrOpt('mgt_net_proxy_netmask',
@ -455,6 +458,7 @@ nsxv_opts = [
help=_("(Optional) Management network default gateway for "
"metadata proxy.")),
cfg.ListOpt('nova_metadata_ips',
default=[],
help=_("(Optional) IP addresses used by Nova metadata "
"service.")),
cfg.PortOpt('nova_metadata_port',
@ -510,6 +514,7 @@ nsxv_opts = [
help=_("If True, the server instance will attempt to "
"initialize the metadata infrastructure")),
cfg.ListOpt('metadata_service_allowed_ports',
default=[],
help=_('List of tcp ports, to be allowed access to the '
'metadata proxy, in addition to the default '
'80,443,8775 tcp ports')),

2
vmware_nsx/tests/unit/nsx_mh/test_opts.py
View File

@ -126,7 +126,7 @@ class ConfigurationTest(base.BaseTestCase):
self.assertEqual(75, cfg.CONF.http_timeout)
self.assertEqual(2, cfg.CONF.retries)
self.assertEqual(2, cfg.CONF.redirects)
self.assertIsNone(cfg.CONF.nsx_controllers)
self.assertEqual([], cfg.CONF.nsx_controllers)
self.assertIsNone(cfg.CONF.default_l3_gw_service_uuid)
self.assertIsNone(cfg.CONF.default_l2_gw_service_uuid)
self.assertEqual('breth0', cfg.CONF.nsx_default_interface_name)