x/vmware-nsx
Code Issues Proposed changes

Remove unused variables from get_devices_details_list

Browse Source 
Initialization of res with empty list is not needed because
res is always assigned with a new value in try/except block.

A method invocation context is created in get_device_details
and need not be initialized in get_devices_details_list because
it is never used there.

Change-Id: I2ff73390ca173cee6d73aaafdcc0c525670e358b
This commit is contained in:
Elena Ezhova 2014-11-27 10:33:04 +03:00
parent 5b7950e24c
commit d92d427df0
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
neutron/agent/rpc.py
View File

@ -89,7 +89,6 @@ class PluginApi(object):
agent_id=agent_id, host=host) agent_id=agent_id, host=host)
def get_devices_details_list(self, context, devices, agent_id, host=None): def get_devices_details_list(self, context, devices, agent_id, host=None):
res = []
try: try:
cctxt = self.client.prepare(version='1.3') cctxt = self.client.prepare(version='1.3')
res = cctxt.call(context, 'get_devices_details_list', res = cctxt.call(context, 'get_devices_details_list',
@ -100,7 +99,6 @@ class PluginApi(object):
# mode, in that DVR routers may not be in the system yet, and # mode, in that DVR routers may not be in the system yet, and
# it might be not necessary to retrieve info about the host. # it might be not necessary to retrieve info about the host.
LOG.warn(_LW('DVR functionality requires a server upgrade.')) LOG.warn(_LW('DVR functionality requires a server upgrade.'))
cctxt = self.client.prepare()
res = [ res = [
self.get_device_details(context, device, agent_id, host) self.get_device_details(context, device, agent_id, host)
for device in devices for device in devices