x/vmware-nsx
Code Issues Proposed changes

Remove unnecessary port deletion

Browse Source 
Fixes bug 1088368

Change-Id: I41b816a8d72d09740ea7d063172a75cedffb8d6d
This commit is contained in:
Gary Kotton 2012-12-10 06:59:30 +00:00
parent 340684b4dd
commit dd97144c08
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
quantum/db/l3_db.py
View File

@ -857,7 +857,6 @@ class L3_NAT_db_mixin(l3.RouterPluginBase):
if len(fixed_ips) > 1: if len(fixed_ips) > 1:
LOG.error(_("Ignoring multiple IPs on router port %s") % LOG.error(_("Ignoring multiple IPs on router port %s") %
port['id']) port['id'])
ports.remove(port)
continue continue
# Empty fixed_ips should not happen # Empty fixed_ips should not happen
fixed_ip = fixed_ips[0] fixed_ip = fixed_ips[0]

2
quantum/tests/unit/test_l3_plugin.py
View File

@ -1363,7 +1363,7 @@ class L3NatDBTestCase(test_db_plugin.QuantumDbPluginV2TestCase):
routers = plugin.get_sync_data(ctx, None) routers = plugin.get_sync_data(ctx, None)
self.assertEqual(1, len(routers)) self.assertEqual(1, len(routers))
interfaces = routers[0].get(l3_constants.INTERFACE_KEY, []) interfaces = routers[0].get(l3_constants.INTERFACE_KEY, [])
self.assertEqual(0, len(interfaces)) self.assertEqual(1, len(interfaces))
# clean-up # clean-up
self._router_interface_action('remove', self._router_interface_action('remove',
r['router']['id'], r['router']['id'],