x/vmware-nsx
Code Issues Proposed changes

l2-population/lb/vxlan : ip neigh add command failed

Browse Source 
we were using ip neigh add command which must be replaced by
ip neigh replace, to avoid error when creating a VM with an ip
previously used by a deleted VM

Change-Id: I2405096d5925ae37efd5f8abcc02b99cf0c9f5d3
Closes-Bug: #1282662
This commit is contained in:
mathieu-rohon 2014-02-20 17:39:00 +01:00
parent 043b4dde00
commit e3e0401672
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
neutron/plugins/linuxbridge/agent/linuxbridge_neutron_agent.py
View File

@ -564,7 +564,7 @@ class LinuxBridgeManager:
return (agent_ip in entries and mac in entries)
def add_fdb_ip_entry(self, mac, ip, interface):
utils.execute(['ip', 'neigh', 'add', ip, 'lladdr', mac,
utils.execute(['ip', 'neigh', 'replace', ip, 'lladdr', mac,
'dev', interface, 'nud', 'permanent'],
root_helper=self.root_helper,
check_exit_code=False)

4
neutron/tests/unit/linuxbridge/test_lb_neutron_agent.py
View File

@ -863,7 +863,7 @@ class TestLinuxBridgeRpcCallbacks(base.BaseTestCase):
'dev', 'vxlan-1', 'dst', 'agent_ip'],
root_helper=self.root_helper,
check_exit_code=False),
mock.call(['ip', 'neigh', 'add', 'port_ip', 'lladdr',
mock.call(['ip', 'neigh', 'replace', 'port_ip', 'lladdr',
'port_mac', 'dev', 'vxlan-1', 'nud', 'permanent'],
root_helper=self.root_helper,
check_exit_code=False),
@ -944,7 +944,7 @@ class TestLinuxBridgeRpcCallbacks(base.BaseTestCase):
self.lb_rpc.fdb_update(None, fdb_entries)
expected = [
mock.call(['ip', 'neigh', 'add', 'port_ip_2', 'lladdr',
mock.call(['ip', 'neigh', 'replace', 'port_ip_2', 'lladdr',
'port_mac', 'dev', 'vxlan-1', 'nud', 'permanent'],
root_helper=self.root_helper,
check_exit_code=False),