x/vmware-nsx
Code Issues Proposed changes

Fix typo in option group shortcut 'aGENT' in NEC plugin

Browse Source 
Also adds a test to check if option group shortcuts work.

Fix bug #1183576

Change-Id: Ib2843f2b2b4e35964fb4bb5280fda8f5c9e2ba0c
This commit is contained in:
Akihiro MOTOKI 2013-05-24 06:23:45 +09:00
parent ee4b047940
commit f0e38f4c75
2 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
quantum/plugins/nec/common/config.py
View File

@ -61,5 +61,5 @@ cfg.CONF.register_opts(scheduler.AGENTS_SCHEDULER_OPTS)
# shortcuts # shortcuts
CONF = cfg.CONF CONF = cfg.CONF
OVS = cfg.CONF.ovs OVS = cfg.CONF.ovs
aGENT = cfg.CONF.AGENT AGENT = cfg.CONF.AGENT
OFC = cfg.CONF.OFC OFC = cfg.CONF.OFC

13
quantum/tests/unit/nec/test_config.py
View File

@ -23,12 +23,21 @@ class ConfigurationTest(base.BaseTestCase):
def test_defaults(self): def test_defaults(self):
self.assertEqual('br-int', config.CONF.ovs.integration_bridge) self.assertEqual('br-int', config.CONF.ovs.integration_bridge)
self.assertEqual(2, config.CONF.AGENT.polling_interval) self.assertEqual(2, config.CONF.AGENT.polling_interval)
self.assertEqual('sudo', config.CONF.AGENT.root_helper) self.assertEqual('sudo', config.CONF.AGENT.root_helper)
self.assertEqual('127.0.0.1', config.CONF.OFC.host) self.assertEqual('127.0.0.1', config.CONF.OFC.host)
self.assertEqual('8888', config.CONF.OFC.port) self.assertEqual('8888', config.CONF.OFC.port)
self.assertEqual('trema', config.CONF.OFC.driver) self.assertEqual('trema', config.CONF.OFC.driver)
self.assertTrue(config.CONF.OFC.enable_packet_filter) self.assertTrue(config.CONF.OFC.enable_packet_filter)
self.assertFalse(config.CONF.OFC.use_ssl) self.assertFalse(config.CONF.OFC.use_ssl)
self.assertEqual(None, config.CONF.OFC.key_file) self.assertIsNone(config.CONF.OFC.key_file)
self.assertEqual(None, config.CONF.OFC.cert_file) self.assertIsNone(config.CONF.OFC.cert_file)
def test_shortcuts(self):
self.assertEqual(config.CONF.ovs.integration_bridge,
config.OVS.integration_bridge)
self.assertEqual(config.CONF.AGENT.polling_interval,
config.AGENT.polling_interval)
self.assertEqual(config.CONF.OFC.host, config.OFC.host)