x/vmware-nsx
Code Issues Proposed changes

Merge "Removes an incorrect and unnecessary return"

Browse Source
This commit is contained in:
Jenkins 2014-02-22 03:23:20 +00:00 committed by Gerrit Code Review
commit f115782e25
2 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
neutron/agent/linux/ovs_lib.py
View File

@ -78,7 +78,6 @@ class BaseOVS(object):
def add_bridge(self, bridge_name): def add_bridge(self, bridge_name):
self.run_vsctl(["--", "--may-exist", "add-br", bridge_name]) self.run_vsctl(["--", "--may-exist", "add-br", bridge_name])
return OVSBridge(bridge_name, self.root_helper)
def delete_bridge(self, bridge_name): def delete_bridge(self, bridge_name):
self.run_vsctl(["--", "--if-exists", "del-br", bridge_name]) self.run_vsctl(["--", "--if-exists", "del-br", bridge_name])

5
neutron/tests/unit/openvswitch/test_ovs_lib.py
View File

@ -37,12 +37,9 @@ class TestBaseOVS(base.BaseTestCase):
def test_add_bridge(self): def test_add_bridge(self):
with mock.patch.object(self.ovs, 'run_vsctl') as mock_vsctl: with mock.patch.object(self.ovs, 'run_vsctl') as mock_vsctl:
bridge = self.ovs.add_bridge(self.br_name) self.ovs.add_bridge(self.br_name)
mock_vsctl.assert_called_with(["--", "--may-exist", mock_vsctl.assert_called_with(["--", "--may-exist",
"add-br", self.br_name]) "add-br", self.br_name])
self.assertEqual(bridge.br_name, self.br_name)
self.assertEqual(bridge.root_helper, self.ovs.root_helper)
def test_delete_bridge(self): def test_delete_bridge(self):
with mock.patch.object(self.ovs, 'run_vsctl') as mock_vsctl: with mock.patch.object(self.ovs, 'run_vsctl') as mock_vsctl: