ec9a37bda0
Additionally, the patch improves the check itself: To check if the currently installed OVS supports the ARP responder feature, we try to add a flow that references an OpenFlow ARP extension via ofctl. The test may fail due to an (expected) Runtime error, or due to some other unexpected error. In such a case the error was previously masked and tossed away. * Clean up ARP responder unit test * Extract ARP responder flow actions to be used by the unit tests, functional test as well as the ARP responder code itself After this patch, if the sanity check returned False but the user never ran it or ignored its results, the OVS agent will output errors to the log every time an ARP entry is (attempted) to be added or removed from the flow table. Closes-Bug: #1323718 Change-Id: I428c954d6561cd398a1e580804a9482969a154af
55 lines
1.9 KiB
Python
55 lines
1.9 KiB
Python
# Copyright (c) 2014 OpenStack Foundation.
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from neutron.cmd.sanity import checks
|
|
from neutron.tests import base
|
|
from neutron.tests.functional import base as functional_base
|
|
|
|
|
|
class SanityTestCase(base.BaseTestCase):
|
|
"""Sanity checks that do not require root access.
|
|
|
|
Tests that just call checks.some_function() are to ensure that
|
|
neutron-sanity-check runs without throwing an exception, as in the case
|
|
where someone modifies the API without updating the check script.
|
|
"""
|
|
|
|
def setUp(self):
|
|
super(SanityTestCase, self).setUp()
|
|
|
|
def test_nova_notify_runs(self):
|
|
checks.nova_notify_supported()
|
|
|
|
|
|
class SanityTestCaseRoot(functional_base.BaseSudoTestCase):
|
|
"""Sanity checks that require root access.
|
|
|
|
Tests that just call checks.some_function() are to ensure that
|
|
neutron-sanity-check runs without throwing an exception, as in the case
|
|
where someone modifies the API without updating the check script.
|
|
"""
|
|
def setUp(self):
|
|
super(SanityTestCaseRoot, self).setUp()
|
|
self.check_sudo_enabled()
|
|
|
|
def test_ovs_vxlan_support_runs(self):
|
|
checks.vxlan_supported(self.root_helper)
|
|
|
|
def test_ovs_patch_support_runs(self):
|
|
checks.patch_supported(self.root_helper)
|
|
|
|
def test_arp_responder_runs(self):
|
|
checks.arp_responder_supported(self.root_helper)
|