8a60ff6b40
blueprint nec-plugin-test-coverage This commit refactors the base class of unit tests for NEC Plugin to make writing new tests easier. Add fake OFC Manager and change unit tests which use OFC Manager mock to using this fake. With this fake, we don't need to set return_value and side_effect to the mock instance of OFC Manager in each test case. This fake keeps all resources on OFC, and returns existence of resources properly. This fake is attached to OFC Manager mock instance by setting all side_effects. We can also set it to raise an exception. Make NEC Plugin configurable in each test case. Now we can configure NEC Plugin by setting string in class value "_nec_ini" which will be written into a temporal file and loaded by NEC plugin. Move setup for callbacks into NecPluginV2TestCase() so that other unit tests can use callbacks. Change-Id: I3a52423bb5813547345677dc49abfea6563dd6cd
90 lines
3.8 KiB
Python
90 lines
3.8 KiB
Python
# vim: tabstop=4 shiftwidth=4 softtabstop=4
|
|
#
|
|
# Copyright 2013, NEC Corporation
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import contextlib
|
|
|
|
import mock
|
|
|
|
from neutron.api.v2 import attributes
|
|
from neutron.extensions import securitygroup as ext_sg
|
|
from neutron import manager
|
|
from neutron.plugins.nec.db import api as ndb # noqa
|
|
from neutron.tests.unit.nec import test_nec_plugin
|
|
from neutron.tests.unit import test_extension_security_group as test_sg
|
|
from neutron.tests.unit import test_security_groups_rpc as test_sg_rpc
|
|
|
|
PLUGIN_NAME = test_nec_plugin.PLUGIN_NAME
|
|
OFC_MANAGER = 'neutron.plugins.nec.nec_plugin.ofc_manager.OFCManager'
|
|
AGENT_NAME = 'neutron.plugins.nec.agent.nec_neutron_agent.NECNeutronAgent'
|
|
NOTIFIER = 'neutron.plugins.nec.nec_plugin.NECPluginV2AgentNotifierApi'
|
|
|
|
|
|
class NecSecurityGroupsTestCase(test_sg.SecurityGroupDBTestCase):
|
|
|
|
def setUp(self, plugin=None):
|
|
test_sg_rpc.set_firewall_driver(test_sg_rpc.FIREWALL_HYBRID_DRIVER)
|
|
self.addCleanup(mock.patch.stopall)
|
|
mock.patch(NOTIFIER).start()
|
|
mock.patch(OFC_MANAGER).start()
|
|
self._attribute_map_bk_ = {}
|
|
for item in attributes.RESOURCE_ATTRIBUTE_MAP:
|
|
self._attribute_map_bk_[item] = (attributes.
|
|
RESOURCE_ATTRIBUTE_MAP[item].
|
|
copy())
|
|
super(NecSecurityGroupsTestCase, self).setUp(PLUGIN_NAME)
|
|
self.notifier = manager.NeutronManager.get_plugin().notifier
|
|
|
|
def tearDown(self):
|
|
super(NecSecurityGroupsTestCase, self).tearDown()
|
|
attributes.RESOURCE_ATTRIBUTE_MAP = self._attribute_map_bk_
|
|
|
|
|
|
class TestNecSecurityGroups(NecSecurityGroupsTestCase,
|
|
test_sg.TestSecurityGroups,
|
|
test_sg_rpc.SGNotificationTestMixin):
|
|
|
|
def test_security_group_get_port_from_device(self):
|
|
with contextlib.nested(self.network(),
|
|
self.security_group()) as (n, sg):
|
|
with self.subnet(n):
|
|
res = self._create_port(self.fmt, n['network']['id'])
|
|
port = self.deserialize(self.fmt, res)
|
|
port_id = port['port']['id']
|
|
sg_id = sg['security_group']['id']
|
|
fixed_ips = port['port']['fixed_ips']
|
|
|
|
data = {'port': {'fixed_ips': fixed_ips,
|
|
'name': port['port']['name'],
|
|
ext_sg.SECURITYGROUPS: [sg_id]}}
|
|
req = self.new_update_request('ports', data, port_id)
|
|
res = self.deserialize(self.fmt,
|
|
req.get_response(self.api))
|
|
|
|
plugin = manager.NeutronManager.get_plugin()
|
|
port_dict = plugin.callback_sg.get_port_from_device(port_id)
|
|
self.assertEqual(port_id, port_dict['id'])
|
|
self.assertEqual([sg_id],
|
|
port_dict[ext_sg.SECURITYGROUPS])
|
|
self.assertEqual([], port_dict['security_group_rules'])
|
|
self.assertEqual([fixed_ips[0]['ip_address']],
|
|
port_dict['fixed_ips'])
|
|
self._delete('ports', port_id)
|
|
|
|
|
|
class TestNecSecurityGroupsXML(TestNecSecurityGroups):
|
|
fmt = 'xml'
|