7d2f6427c9
The API implemented by ML2 mechanism drivers included three methods related to port binding that were called within DB transactions, but that could potentially involve communication with controllers or devices that should not be done within transactions. A subsequent patch will move the calls to bind_port() outside of tranactions. This patch eliminates the other two methods from the MechanismDriver API. The validate_port_binding() method was previously called on the bound mechanism driver to check whether an existing binding was still valid, so that the port could be rebound if something changed. But since nova has no way to handle changes to binding:vif_type or binding:vif_details after a port is initially plugged, this turned out not to be useful, so the method has been removed from the MechanismDriver API. Now, once a port is successfully bound, the binding remains until the port is deleted or any of it's binding:host_id, binding:vnic_type, or binding:profile attribute values are changed. The unbind_port() method was previously called on the bound mechanism driver as an existing binding was removed. This method was not used by any existing mechanism drivers, and was redundant with the update_port_precommit() and update_port_postcommit() methods that are called on all mechanism drivers when an existing binding is removed, so this method has also been removed from the driver API. Eliminating the unbind_port() call allows the binding details to be made available via the PortContext in delete_port_postcommit() calls, completing the resolution of bug 1276395. Closes-bug: 1276395 Partial-bug: 1276391 Change-Id: I70fb65b478373c4f07f5273baa097fc50e5ba2ef
121 lines
4.7 KiB
Python
121 lines
4.7 KiB
Python
# Copyright (c) 2013 OpenStack Foundation
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from neutron.openstack.common import log
|
|
from neutron.plugins.ml2 import driver_api as api
|
|
|
|
LOG = log.getLogger(__name__)
|
|
|
|
|
|
class LoggerMechanismDriver(api.MechanismDriver):
|
|
"""Mechanism driver that logs all calls and parameters made.
|
|
|
|
Generally used for testing and debugging.
|
|
"""
|
|
|
|
def initialize(self):
|
|
pass
|
|
|
|
def _log_network_call(self, method_name, context):
|
|
LOG.info(_("%(method)s called with network settings %(current)s "
|
|
"(original settings %(original)s) and "
|
|
"network segments %(segments)s"),
|
|
{'method': method_name,
|
|
'current': context.current,
|
|
'original': context.original,
|
|
'segments': context.network_segments})
|
|
|
|
def create_network_precommit(self, context):
|
|
self._log_network_call("create_network_precommit", context)
|
|
|
|
def create_network_postcommit(self, context):
|
|
self._log_network_call("create_network_postcommit", context)
|
|
|
|
def update_network_precommit(self, context):
|
|
self._log_network_call("update_network_precommit", context)
|
|
|
|
def update_network_postcommit(self, context):
|
|
self._log_network_call("update_network_postcommit", context)
|
|
|
|
def delete_network_precommit(self, context):
|
|
self._log_network_call("delete_network_precommit", context)
|
|
|
|
def delete_network_postcommit(self, context):
|
|
self._log_network_call("delete_network_postcommit", context)
|
|
|
|
def _log_subnet_call(self, method_name, context):
|
|
LOG.info(_("%(method)s called with subnet settings %(current)s "
|
|
"(original settings %(original)s)"),
|
|
{'method': method_name,
|
|
'current': context.current,
|
|
'original': context.original})
|
|
|
|
def create_subnet_precommit(self, context):
|
|
self._log_subnet_call("create_subnet_precommit", context)
|
|
|
|
def create_subnet_postcommit(self, context):
|
|
self._log_subnet_call("create_subnet_postcommit", context)
|
|
|
|
def update_subnet_precommit(self, context):
|
|
self._log_subnet_call("update_subnet_precommit", context)
|
|
|
|
def update_subnet_postcommit(self, context):
|
|
self._log_subnet_call("update_subnet_postcommit", context)
|
|
|
|
def delete_subnet_precommit(self, context):
|
|
self._log_subnet_call("delete_subnet_precommit", context)
|
|
|
|
def delete_subnet_postcommit(self, context):
|
|
self._log_subnet_call("delete_subnet_postcommit", context)
|
|
|
|
def _log_port_call(self, method_name, context):
|
|
network_context = context.network
|
|
LOG.info(_("%(method)s called with port settings %(current)s "
|
|
"(original settings %(original)s) "
|
|
"bound to segment %(segment)s "
|
|
"(original segment %(original_segment)s) "
|
|
"using driver %(driver)s "
|
|
"(original driver %(original_driver)s) "
|
|
"on network %(network)s"),
|
|
{'method': method_name,
|
|
'current': context.current,
|
|
'original': context.original,
|
|
'segment': context.bound_segment,
|
|
'original_segment': context.original_bound_segment,
|
|
'driver': context.bound_driver,
|
|
'original_driver': context.original_bound_driver,
|
|
'network': network_context.current})
|
|
|
|
def create_port_precommit(self, context):
|
|
self._log_port_call("create_port_precommit", context)
|
|
|
|
def create_port_postcommit(self, context):
|
|
self._log_port_call("create_port_postcommit", context)
|
|
|
|
def update_port_precommit(self, context):
|
|
self._log_port_call("update_port_precommit", context)
|
|
|
|
def update_port_postcommit(self, context):
|
|
self._log_port_call("update_port_postcommit", context)
|
|
|
|
def delete_port_precommit(self, context):
|
|
self._log_port_call("delete_port_precommit", context)
|
|
|
|
def delete_port_postcommit(self, context):
|
|
self._log_port_call("delete_port_postcommit", context)
|
|
|
|
def bind_port(self, context):
|
|
self._log_port_call("bind_port", context)
|