Tong Liu 2c55108ef4 NSXv3: Fix L7 rule create/delete base on latest API
The platform side finalized the API for LbRule including
LbRuleAction, LbRuleCondition and LbRuleMatchType. Also it enforces
LB rule deletion that the rule cannot be deleted with if it is
still attached to a virtual server. This patch fix these based on
platform changes.

Change-Id: Id3709c480eb92a7d369851248f302267da0a64ef
2017-09-06 14:26:38 -07:00

82 lines
3.4 KiB
Python

# Copyright 2017 VMware, Inc.
# All Rights Reserved
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
from neutron_lib import exceptions as n_exc
from oslo_log import helpers as log_helpers
from oslo_log import log as logging
from vmware_nsx._i18n import _
from vmware_nsx.db import db as nsx_db
from vmware_nsx.services.lbaas import base_mgr
from vmware_nsxlib.v3 import exceptions as nsxlib_exc
LOG = logging.getLogger(__name__)
class EdgeL7PolicyManager(base_mgr.Nsxv3LoadbalancerBaseManager):
@log_helpers.log_method_call
def __init__(self):
super(EdgeL7PolicyManager, self).__init__()
@log_helpers.log_method_call
def _l7policy_action(self, context, policy, action, delete=False):
try:
self.lbv2_driver.l7policy.successful_completion(
context, policy, delete=delete)
except Exception as e:
self.lbv2_driver.l7policy.failed_completion(context, policy)
msg = (_('Failed to %(action)s l7policy %(err)s') %
{'action': action, 'err': e})
resource = 'lbaas-l7policy-%s' % action
raise n_exc.BadRequest(resource=resource, msg=msg)
@log_helpers.log_method_call
def create(self, context, policy):
self._l7policy_action(context, policy, 'create')
@log_helpers.log_method_call
def update(self, context, old_policy, new_policy):
self._l7policy_action(context, new_policy, 'update')
@log_helpers.log_method_call
def delete(self, context, policy):
lb_id = policy.listener.loadbalancer_id
vs_client = self.core_plugin.nsxlib.load_balancer.virtual_server
rule_client = self.core_plugin.nsxlib.load_balancer.rule
for rule in policy.rules:
binding = nsx_db.get_nsx_lbaas_l7rule_binding(
context.session, lb_id, policy.id, rule.id)
if binding:
vs_id = binding['lb_vs_id']
rule_id = binding['lb_rule_id']
try:
# Update virtual server to remove lb rule
vs_client.remove_rule(vs_id, rule_id)
rule_client.delete(rule_id)
except nsxlib_exc.ResourceNotFound:
LOG.warning('LB rule %(rule)s is not found on NSX',
{'rule': rule_id})
except nsxlib_exc.ManagerError:
self.lbv2_driver.l7policy.failed_completion(
context, policy)
msg = (_('Failed to delete lb rule: %(rule)s') %
{'rule': rule.id})
raise n_exc.BadRequest(resource='lbaas-l7rule-delete',
msg=msg)
nsx_db.delete_nsx_lbaas_l7rule_binding(
context.session, lb_id, policy.id, rule.id)
self.lbv2_driver.l7policy.successful_completion(
context, policy, delete=True)