A set of Neutron drivers for the VMware NSX.
8ec8987c31
Currently, several plugins already check config options at __init__() for validity and will exit, if the settings are incorrect. However, most (all?) config option definitions have default values, so if the option is missing, a valid, but maybe unexpected value will be used. This is what occurred in the bug. The proposed fix is to take a config option, sql_connection, which is used by many plugins, and remove the default value. Then, at init time, when the config option is used in configure_db(), a check is made for the value. If the value is not set, a warning is logged and the value is set to the default, for db/api.py. It is expected that this will be the only module to consume this config option. Added UT to check that log warning is issued. Also, changed the timing so that the test takes 0.25 secs vs 12 secs. Removed UTs in two plugin tests that checked the default value for sql_connection. Other alternatives explored in previous patches, were to either raise an exception, or mark this config option as "required". This resulted in a large number of changes to tests, and required config overrides in plugins that imported quantum.db.api, but did not use sql_connection. In order to keep this solution (of this log-hanging fruit) fix, the proposed, simpler change is being made. Some cleanup to the Cisco plugin test case was also made, so that the mock was more in line with what production code does. bug 1059923 Change-Id: I8c2a4e05231ac4e172d0dccece067e6fdb354341 |
||
|---|---|---|
| bin | ||
| doc | ||
| etc | ||
| quantum | ||
| tools | ||
| .bzrignore | ||
| .coveragerc | ||
| .gitignore | ||
| .gitreview | ||
| .mailmap | ||
| .pylintrc | ||
| babel.cfg | ||
| HACKING.rst | ||
| LICENSE | ||
| MANIFEST.in | ||
| openstack-common.conf | ||
| README | ||
| run_tests.py | ||
| run_tests.sh | ||
| setup.cfg | ||
| setup.py | ||
| TESTING | ||
| tox.ini | ||
# -- Welcome! You have come across a cloud computing network fabric controller. It has identified itself as "Quantum." It aims to tame your (cloud) networking! # -- External Resources: The homepage for Quantum is: http://launchpad.net/quantum . Use this site for asking for help, and filing bugs. Code is available on github at <http://github.com/openstack/quantum>. The latest and most in-depth documentation on how to use Quantum is available at: <http://docs.openstack.org>. This includes: Quantum Administrator Guide http://docs.openstack.org/trunk/openstack-network/admin/content/ Quantum API Reference: http://docs.openstack.org/api/openstack-network/2.0/content/ The start of some developer documentation is available at: http://wiki.openstack.org/QuantumDevelopment For help using or hacking on Quantum, you can send mail to <mailto:openstack-dev@lists.openstack.org>.