e2c1bcfc94
Delete port used to call update_port_down to calculate its fdb entries during delete_port_precommit. But during the pre-commit, the port is still up, so update_port_down acts as if there was still one port on the agent, and doesn't add flooding entry in its fdb_entries. Closes bug #1282141 Change-Id: Icedd02f33d999200505950beb9169ae3634e551b
230 lines
8.9 KiB
Python
230 lines
8.9 KiB
Python
# Copyright (c) 2013 OpenStack Foundation.
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
#
|
|
# @author: Sylvain Afchain, eNovance SAS
|
|
# @author: Francois Eleouet, Orange
|
|
# @author: Mathieu Rohon, Orange
|
|
|
|
from oslo.config import cfg
|
|
|
|
from neutron.common import constants as const
|
|
from neutron import context as n_context
|
|
from neutron.db import api as db_api
|
|
from neutron.openstack.common import log as logging
|
|
from neutron.plugins.ml2 import driver_api as api
|
|
from neutron.plugins.ml2.drivers.l2pop import config # noqa
|
|
from neutron.plugins.ml2.drivers.l2pop import db as l2pop_db
|
|
from neutron.plugins.ml2.drivers.l2pop import rpc as l2pop_rpc
|
|
|
|
LOG = logging.getLogger(__name__)
|
|
|
|
|
|
class L2populationMechanismDriver(api.MechanismDriver,
|
|
l2pop_db.L2populationDbMixin):
|
|
|
|
def initialize(self):
|
|
LOG.debug(_("Experimental L2 population driver"))
|
|
self.rpc_ctx = n_context.get_admin_context_without_session()
|
|
|
|
def _get_port_fdb_entries(self, port):
|
|
return [[port['mac_address'],
|
|
ip['ip_address']] for ip in port['fixed_ips']]
|
|
|
|
def delete_port_precommit(self, context):
|
|
# TODO(matrohon): revisit once the original bound segment will be
|
|
# available in delete_port_postcommit. in delete_port_postcommit
|
|
# agent_active_ports will be equal to 0, and the _update_port_down
|
|
# won't need agent_active_ports_count_for_flooding anymore
|
|
self.remove_fdb_entries = self._update_port_down(context, 1)
|
|
|
|
def delete_port_postcommit(self, context):
|
|
l2pop_rpc.L2populationAgentNotify.remove_fdb_entries(
|
|
self.rpc_ctx, self.remove_fdb_entries)
|
|
|
|
def _get_diff_ips(self, orig, port):
|
|
orig_ips = set([ip['ip_address'] for ip in orig['fixed_ips']])
|
|
port_ips = set([ip['ip_address'] for ip in port['fixed_ips']])
|
|
|
|
# check if an ip has been added or removed
|
|
orig_chg_ips = orig_ips.difference(port_ips)
|
|
port_chg_ips = port_ips.difference(orig_ips)
|
|
|
|
if orig_chg_ips or port_chg_ips:
|
|
return orig_chg_ips, port_chg_ips
|
|
|
|
def _fixed_ips_changed(self, context, orig, port):
|
|
diff_ips = self._get_diff_ips(orig, port)
|
|
if not diff_ips:
|
|
return
|
|
orig_ips, port_ips = diff_ips
|
|
|
|
port_infos = self._get_port_infos(context, orig)
|
|
if not port_infos:
|
|
return
|
|
agent, agent_ip, segment, port_fdb_entries = port_infos
|
|
|
|
orig_mac_ip = [[port['mac_address'], ip] for ip in orig_ips]
|
|
port_mac_ip = [[port['mac_address'], ip] for ip in port_ips]
|
|
|
|
upd_fdb_entries = {port['network_id']: {agent_ip: {}}}
|
|
|
|
ports = upd_fdb_entries[port['network_id']][agent_ip]
|
|
if orig_mac_ip:
|
|
ports['before'] = orig_mac_ip
|
|
|
|
if port_mac_ip:
|
|
ports['after'] = port_mac_ip
|
|
|
|
l2pop_rpc.L2populationAgentNotify.update_fdb_entries(
|
|
self.rpc_ctx, {'chg_ip': upd_fdb_entries})
|
|
|
|
return True
|
|
|
|
def update_port_postcommit(self, context):
|
|
port = context.current
|
|
orig = context.original
|
|
|
|
if port['status'] == orig['status']:
|
|
self._fixed_ips_changed(context, orig, port)
|
|
elif port['status'] == const.PORT_STATUS_ACTIVE:
|
|
self._update_port_up(context)
|
|
elif port['status'] == const.PORT_STATUS_DOWN:
|
|
fdb_entries = self._update_port_down(context)
|
|
l2pop_rpc.L2populationAgentNotify.remove_fdb_entries(
|
|
self.rpc_ctx, fdb_entries)
|
|
|
|
def _get_port_infos(self, context, port):
|
|
agent_host = port['binding:host_id']
|
|
if not agent_host:
|
|
return
|
|
|
|
session = db_api.get_session()
|
|
agent = self.get_agent_by_host(session, agent_host)
|
|
if not agent:
|
|
return
|
|
|
|
agent_ip = self.get_agent_ip(agent)
|
|
if not agent_ip:
|
|
LOG.warning(_("Unable to retrieve the agent ip, check the agent "
|
|
"configuration."))
|
|
return
|
|
|
|
segment = context.bound_segment
|
|
if not segment:
|
|
LOG.warning(_("Port %(port)s updated by agent %(agent)s "
|
|
"isn't bound to any segment"),
|
|
{'port': port['id'], 'agent': agent})
|
|
return
|
|
|
|
tunnel_types = self.get_agent_tunnel_types(agent)
|
|
if segment['network_type'] not in tunnel_types:
|
|
return
|
|
|
|
fdb_entries = self._get_port_fdb_entries(port)
|
|
|
|
return agent, agent_ip, segment, fdb_entries
|
|
|
|
def _update_port_up(self, context):
|
|
port_context = context.current
|
|
port_infos = self._get_port_infos(context, port_context)
|
|
if not port_infos:
|
|
return
|
|
agent, agent_ip, segment, port_fdb_entries = port_infos
|
|
|
|
agent_host = port_context['binding:host_id']
|
|
network_id = port_context['network_id']
|
|
|
|
session = db_api.get_session()
|
|
agent_active_ports = self.get_agent_network_active_port_count(
|
|
session, agent_host, network_id)
|
|
|
|
other_fdb_entries = {network_id:
|
|
{'segment_id': segment['segmentation_id'],
|
|
'network_type': segment['network_type'],
|
|
'ports': {agent_ip: []}}}
|
|
|
|
if agent_active_ports == 1 or (
|
|
self.get_agent_uptime(agent) < cfg.CONF.l2pop.agent_boot_time):
|
|
# First port activated on current agent in this network,
|
|
# we have to provide it with the whole list of fdb entries
|
|
agent_fdb_entries = {network_id:
|
|
{'segment_id': segment['segmentation_id'],
|
|
'network_type': segment['network_type'],
|
|
'ports': {}}}
|
|
ports = agent_fdb_entries[network_id]['ports']
|
|
|
|
network_ports = self.get_network_ports(session, network_id)
|
|
for network_port in network_ports:
|
|
binding, agent = network_port
|
|
if agent.host == agent_host:
|
|
continue
|
|
|
|
ip = self.get_agent_ip(agent)
|
|
if not ip:
|
|
LOG.debug(_("Unable to retrieve the agent ip, check "
|
|
"the agent %(agent_host)s configuration."),
|
|
{'agent_host': agent.host})
|
|
continue
|
|
|
|
agent_ports = ports.get(ip, [const.FLOODING_ENTRY])
|
|
agent_ports += self._get_port_fdb_entries(binding.port)
|
|
ports[ip] = agent_ports
|
|
|
|
# And notify other agents to add flooding entry
|
|
other_fdb_entries[network_id]['ports'][agent_ip].append(
|
|
const.FLOODING_ENTRY)
|
|
|
|
if ports.keys():
|
|
l2pop_rpc.L2populationAgentNotify.add_fdb_entries(
|
|
self.rpc_ctx, agent_fdb_entries, agent_host)
|
|
|
|
# Notify other agents to add fdb rule for current port
|
|
other_fdb_entries[network_id]['ports'][agent_ip] += port_fdb_entries
|
|
|
|
l2pop_rpc.L2populationAgentNotify.add_fdb_entries(self.rpc_ctx,
|
|
other_fdb_entries)
|
|
|
|
def _update_port_down(self, context,
|
|
agent_active_ports_count_for_flooding=0):
|
|
port_context = context.current
|
|
port_infos = self._get_port_infos(context, port_context)
|
|
if not port_infos:
|
|
return
|
|
agent, agent_ip, segment, port_fdb_entries = port_infos
|
|
|
|
agent_host = port_context['binding:host_id']
|
|
network_id = port_context['network_id']
|
|
|
|
session = db_api.get_session()
|
|
agent_active_ports = self.get_agent_network_active_port_count(
|
|
session, agent_host, network_id)
|
|
|
|
other_fdb_entries = {network_id:
|
|
{'segment_id': segment['segmentation_id'],
|
|
'network_type': segment['network_type'],
|
|
'ports': {agent_ip: []}}}
|
|
|
|
if agent_active_ports == agent_active_ports_count_for_flooding:
|
|
# Agent is removing its last activated port in this network,
|
|
# other agents needs to be notified to delete their flooding entry.
|
|
other_fdb_entries[network_id]['ports'][agent_ip].append(
|
|
const.FLOODING_ENTRY)
|
|
|
|
# Notify other agents to remove fdb rule for current port
|
|
fdb_entries = self._get_port_fdb_entries(port_context)
|
|
other_fdb_entries[network_id]['ports'][agent_ip] += fdb_entries
|
|
|
|
return other_fdb_entries
|