
Create an openstack client plugin for vmware nsx, and add the some of the extensions suport: router-type, router-size, subnet dhcp-mtu and dns-search-domain and port provider security groups and vnic index Work for future patches: - More unit tests (provider-security-groups) - Add the rest of the extensions Change-Id: I5b335de000b310cbcbb9a2f81483fd28f8d9afea
152 lines
5.3 KiB
Python
152 lines
5.3 KiB
Python
# Copyright 2016 VMware, Inc.
|
|
# All Rights Reserved
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import mock
|
|
import re
|
|
|
|
from openstackclient.tests.unit.network.v2 import test_router
|
|
from openstackclient.tests.unit import utils as tests_utils
|
|
|
|
from vmware_nsx.extensions import routersize
|
|
from vmware_nsx.extensions import routertype
|
|
from vmware_nsx.osc.v2 import router
|
|
|
|
|
|
supported_extensions = ('nsxv-router-size', 'nsxv-router-type')
|
|
|
|
|
|
class TestCreateRouter(test_router.TestCreateRouter):
|
|
|
|
def setUp(self):
|
|
super(TestCreateRouter, self).setUp()
|
|
# Get the command object to test
|
|
self.cmd = router.NsxCreateRouter(self.app, self.namespace)
|
|
# mock the relevant extensions
|
|
get_ext = mock.patch('vmware_nsx.osc.v2.utils.get_extensions').start()
|
|
get_ext.return_value = supported_extensions
|
|
|
|
def _test_create_with_arg_and_val(self, arg_name, arg_val, is_valid=True):
|
|
self.network.create_router.reset_mock()
|
|
# add '--' to the arg name and change '_' to '-'
|
|
conv_name = '--' + re.sub('_', '-', arg_name)
|
|
arglist = [
|
|
self.new_router.name,
|
|
conv_name, arg_val
|
|
]
|
|
verifylist = [
|
|
('name', self.new_router.name),
|
|
(arg_name, arg_val),
|
|
('enable', True),
|
|
('distributed', False),
|
|
]
|
|
if not is_valid:
|
|
self.assertRaises(tests_utils.ParserException, self.check_parser,
|
|
self.cmd, arglist, verifylist)
|
|
return
|
|
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
|
|
columns, data = (self.cmd.take_action(parsed_args))
|
|
self.network.create_router.assert_called_once_with(**{
|
|
'admin_state_up': True,
|
|
'name': self.new_router.name,
|
|
arg_name: arg_val,
|
|
})
|
|
|
|
self.assertEqual(self.columns, columns)
|
|
self.assertEqual(self.data, data)
|
|
|
|
def _test_create_with_size(self, size, is_valid=True):
|
|
self._test_create_with_arg_and_val('router_size', size, is_valid)
|
|
|
|
def test_create_with_sizes(self):
|
|
# check all router types
|
|
for rtr_size in routersize.VALID_EDGE_SIZES:
|
|
self._test_create_with_size(rtr_size)
|
|
|
|
def test_create_with_illegal_size(self):
|
|
self._test_create_with_size('illegal', is_valid=False)
|
|
|
|
def _test_create_with_type(self, rtr_type, is_valid=True):
|
|
self._test_create_with_arg_and_val('router_type', rtr_type, is_valid)
|
|
|
|
def test_create_with_types(self):
|
|
# check all router types
|
|
for rtr_type in routertype.VALID_TYPES:
|
|
self._test_create_with_type(rtr_type)
|
|
|
|
def test_create_with_illegal_type(self):
|
|
self._test_create_with_type('illegal', is_valid=False)
|
|
|
|
|
|
class TestSetRouter(test_router.TestSetRouter):
|
|
|
|
def setUp(self):
|
|
super(TestSetRouter, self).setUp()
|
|
# Get the command object to test
|
|
self.cmd = router.NsxSetRouter(self.app, self.namespace)
|
|
# mock the relevant extensions
|
|
get_ext = mock.patch('vmware_nsx.osc.v2.utils.get_extensions').start()
|
|
get_ext.return_value = supported_extensions
|
|
|
|
def _test_set_with_arg_and_val(self, arg_name, arg_val, is_valid=True):
|
|
self.network.update_router.reset_mock()
|
|
# add '--' to the arg name and change '_' to '-'
|
|
conv_name = '--' + re.sub('_', '-', arg_name)
|
|
arglist = [
|
|
self._router.name,
|
|
conv_name, arg_val
|
|
]
|
|
verifylist = [
|
|
('router', self._router.name),
|
|
(arg_name, arg_val)
|
|
]
|
|
if not is_valid:
|
|
self.assertRaises(tests_utils.ParserException, self.check_parser,
|
|
self.cmd, arglist, verifylist)
|
|
return
|
|
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
|
|
result = self.cmd.take_action(parsed_args)
|
|
|
|
attrs = {arg_name: arg_val}
|
|
self.network.update_router.assert_called_once_with(
|
|
self._router, **attrs)
|
|
self.assertIsNone(result)
|
|
|
|
def _test_set_size(self, size, is_valid=True):
|
|
self._test_set_with_arg_and_val('router_size', size, is_valid)
|
|
|
|
def test_set_sizes(self):
|
|
# check all router types
|
|
for rtr_size in routersize.VALID_EDGE_SIZES:
|
|
self._test_set_size(rtr_size)
|
|
|
|
def test_set_illegal_size(self):
|
|
# check illegal size
|
|
self._test_set_size('illegal', is_valid=False)
|
|
|
|
def _test_set_type(self, rtr_type, is_valid=True):
|
|
self._test_set_with_arg_and_val('router_type', rtr_type, is_valid)
|
|
|
|
def test_set_types(self):
|
|
# check all router types
|
|
for rtr_type in routertype.VALID_TYPES:
|
|
self._test_set_type(rtr_type)
|
|
|
|
def test_set_illegal_type(self):
|
|
self._test_set_type('illegal', is_valid=False)
|