c3fd3feba6
Fixes bug 1127664 Network cannot be created in NEC plugin when OFC network ID is unique inside a tenant. Some OFC implmenetations generate a network ID unique inside a tenant. In this case generated network IDs on can be duplicated in system-wide. To fix it, this changes resource ID on OFC to REST URI to make sure IDs on OFC globally unique. Fixes bug 1120962 Make sure NEC plugin creates shared networks In Quantum resource relationship is not limited inside a tenant. E.g., a non-owner tenant can create a port on a shared network. To deal with it the provider layer should not be aware of tenants each resource belongs to even when it has a kind of tenant concept. This commit changes ofc_manager to pass a parent resource for resource creation and identify a resouce by REST URI used to access OFC resources. It decouples Quantum resource access model from OFC resource models. OFC IDs created before this commit are also looked up. Primary keys of OFC ID mapping tables are changed to quantum_id because most of all accesses to these mapping tables are done by quantum_id. However the current version of alembic does not support changing primary keys, so new OFC ID mapping tables for tenant, network, port and packet filter are created. Dropping the previous mapping tables will be done along with the data migration logic. This commit also changes the following minor issues. - Make sure ID on ProgrammableFlow OpenFlow controller (PFC) is less than 32 chars. The current PFC accepts only 31 chars max as ID and 127 chars as a description string. - Some database accesses created their own session and did not support subtransactions. Make sure to use context.session passed from the API layer. - Removes Unused methods (update_network, update_port) in trema/pfc drivers. Change-Id: Ib4bb830e5f537c789974fa7b77f06eaeacb65333
277 lines
12 KiB
Python
277 lines
12 KiB
Python
# vim: tabstop=4 shiftwidth=4 softtabstop=4
|
|
|
|
# Copyright 2012 NEC Corporation. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
# @author: Ryota MIBU
|
|
|
|
import unittest
|
|
|
|
from quantum import context
|
|
from quantum.openstack.common import uuidutils
|
|
from quantum.plugins.nec.common import config
|
|
from quantum.plugins.nec.db import api as ndb
|
|
from quantum.plugins.nec.db import models as nmodels
|
|
from quantum.plugins.nec import ofc_manager
|
|
|
|
|
|
class OFCManagerTestBase(object):
|
|
"""Class conisting of OFCManager unit tests"""
|
|
|
|
def setUp(self):
|
|
driver = "quantum.tests.unit.nec.stub_ofc_driver.StubOFCDriver"
|
|
config.CONF.set_override('driver', driver, 'OFC')
|
|
ndb.initialize()
|
|
self.ofc = ofc_manager.OFCManager()
|
|
self.ctx = context.get_admin_context()
|
|
|
|
def tearDown(self):
|
|
ndb.clear_db()
|
|
|
|
def get_random_params(self):
|
|
"""create random parameters for portinfo test"""
|
|
tenant = uuidutils.generate_uuid()
|
|
network = uuidutils.generate_uuid()
|
|
port = uuidutils.generate_uuid()
|
|
_filter = uuidutils.generate_uuid()
|
|
none = uuidutils.generate_uuid()
|
|
return tenant, network, port, _filter, none
|
|
|
|
|
|
class OFCManagerTest(OFCManagerTestBase, unittest.TestCase):
|
|
def testa_create_ofc_tenant(self):
|
|
"""test create ofc_tenant"""
|
|
t, n, p, f, none = self.get_random_params()
|
|
self.assertFalse(ndb.get_ofc_item(self.ctx.session, 'ofc_tenant', t))
|
|
self.ofc.create_ofc_tenant(self.ctx, t)
|
|
self.assertTrue(ndb.get_ofc_item(self.ctx.session, 'ofc_tenant', t))
|
|
tenant = ndb.get_ofc_item(self.ctx.session, 'ofc_tenant', t)
|
|
self.assertEqual(tenant.ofc_id, "ofc-" + t[:-4])
|
|
|
|
def testb_exists_ofc_tenant(self):
|
|
"""test exists_ofc_tenant"""
|
|
t, n, p, f, none = self.get_random_params()
|
|
self.assertFalse(self.ofc.exists_ofc_tenant(self.ctx, t))
|
|
self.ofc.create_ofc_tenant(self.ctx, t)
|
|
self.assertTrue(self.ofc.exists_ofc_tenant(self.ctx, t))
|
|
|
|
def testc_delete_ofc_tenant(self):
|
|
"""test delete ofc_tenant"""
|
|
t, n, p, f, none = self.get_random_params()
|
|
self.ofc.create_ofc_tenant(self.ctx, t)
|
|
self.assertTrue(ndb.get_ofc_item(self.ctx.session, 'ofc_tenant', t))
|
|
self.ofc.delete_ofc_tenant(self.ctx, t)
|
|
self.assertFalse(ndb.get_ofc_item(self.ctx.session, 'ofc_tenant', t))
|
|
|
|
def testd_create_ofc_network(self):
|
|
"""test create ofc_network"""
|
|
t, n, p, f, none = self.get_random_params()
|
|
self.ofc.create_ofc_tenant(self.ctx, t)
|
|
self.assertFalse(ndb.get_ofc_item(self.ctx.session, 'ofc_network', n))
|
|
self.ofc.create_ofc_network(self.ctx, t, n)
|
|
self.assertTrue(ndb.get_ofc_item(self.ctx.session, 'ofc_network', n))
|
|
network = ndb.get_ofc_item(self.ctx.session, 'ofc_network', n)
|
|
self.assertEqual(network.ofc_id, "ofc-" + n[:-4])
|
|
|
|
def teste_exists_ofc_network(self):
|
|
"""test exists_ofc_network"""
|
|
t, n, p, f, none = self.get_random_params()
|
|
self.ofc.create_ofc_tenant(self.ctx, t)
|
|
self.assertFalse(self.ofc.exists_ofc_network(self.ctx, n))
|
|
self.ofc.create_ofc_network(self.ctx, t, n)
|
|
self.assertTrue(self.ofc.exists_ofc_network(self.ctx, n))
|
|
|
|
def testf_delete_ofc_network(self):
|
|
"""test delete ofc_network"""
|
|
t, n, p, f, none = self.get_random_params()
|
|
self.ofc.create_ofc_tenant(self.ctx, t)
|
|
self.ofc.create_ofc_network(self.ctx, t, n)
|
|
self.assertTrue(ndb.get_ofc_item(self.ctx.session, 'ofc_network', n))
|
|
self.ofc.delete_ofc_network(self.ctx, n, {'tenant_id': t})
|
|
self.assertFalse(ndb.get_ofc_item(self.ctx.session, 'ofc_network', n))
|
|
|
|
def testg_create_ofc_port(self):
|
|
"""test create ofc_port"""
|
|
t, n, p, f, none = self.get_random_params()
|
|
self.ofc.create_ofc_tenant(self.ctx, t)
|
|
self.ofc.create_ofc_network(self.ctx, t, n)
|
|
ndb.add_portinfo(self.ctx.session, p, "0xabc", 1, 65535,
|
|
"00:11:22:33:44:55")
|
|
self.assertFalse(ndb.get_ofc_item(self.ctx.session, 'ofc_port', p))
|
|
port = {'tenant_id': t, 'network_id': n}
|
|
self.ofc.create_ofc_port(self.ctx, p, port)
|
|
self.assertTrue(ndb.get_ofc_item(self.ctx.session, 'ofc_port', p))
|
|
port = ndb.get_ofc_item(self.ctx.session, 'ofc_port', p)
|
|
self.assertEqual(port.ofc_id, "ofc-" + p[:-4])
|
|
|
|
def testh_exists_ofc_port(self):
|
|
"""test exists_ofc_port"""
|
|
t, n, p, f, none = self.get_random_params()
|
|
self.ofc.create_ofc_tenant(self.ctx, t)
|
|
self.ofc.create_ofc_network(self.ctx, t, n)
|
|
ndb.add_portinfo(self.ctx.session, p, "0xabc", 2, 65535,
|
|
"00:12:22:33:44:55")
|
|
self.assertFalse(self.ofc.exists_ofc_port(self.ctx, p))
|
|
port = {'tenant_id': t, 'network_id': n}
|
|
self.ofc.create_ofc_port(self.ctx, p, port)
|
|
self.assertTrue(self.ofc.exists_ofc_port(self.ctx, p))
|
|
|
|
def testi_delete_ofc_port(self):
|
|
"""test delete ofc_port"""
|
|
t, n, p, f, none = self.get_random_params()
|
|
self.ofc.create_ofc_tenant(self.ctx, t)
|
|
self.ofc.create_ofc_network(self.ctx, t, n)
|
|
ndb.add_portinfo(self.ctx.session, p, "0xabc", 3, 65535,
|
|
"00:13:22:33:44:55")
|
|
port = {'tenant_id': t, 'network_id': n}
|
|
self.ofc.create_ofc_port(self.ctx, p, port)
|
|
self.assertTrue(ndb.get_ofc_item(self.ctx.session, 'ofc_port', p))
|
|
self.ofc.delete_ofc_port(self.ctx, p, port)
|
|
self.assertFalse(ndb.get_ofc_item(self.ctx.session, 'ofc_port', p))
|
|
|
|
def testj_create_ofc_packet_filter(self):
|
|
"""test create ofc_filter"""
|
|
t, n, p, f, none = self.get_random_params()
|
|
self.ofc.create_ofc_tenant(self.ctx, t)
|
|
self.ofc.create_ofc_network(self.ctx, t, n)
|
|
self.assertFalse(ndb.get_ofc_item(self.ctx.session,
|
|
'ofc_packet_filter', f))
|
|
pf = {'tenant_id': t, 'network_id': n}
|
|
self.ofc.create_ofc_packet_filter(self.ctx, f, pf)
|
|
self.assertTrue(ndb.get_ofc_item(self.ctx.session,
|
|
'ofc_packet_filter', f))
|
|
_filter = ndb.get_ofc_item(self.ctx.session, 'ofc_packet_filter', f)
|
|
self.assertEqual(_filter.ofc_id, "ofc-" + f[:-4])
|
|
|
|
def testk_exists_ofc_packet_filter(self):
|
|
"""test exists_ofc_packet_filter"""
|
|
t, n, p, f, none = self.get_random_params()
|
|
self.ofc.create_ofc_tenant(self.ctx, t)
|
|
self.ofc.create_ofc_network(self.ctx, t, n)
|
|
self.assertFalse(self.ofc.exists_ofc_packet_filter(self.ctx, f))
|
|
pf = {'tenant_id': t, 'network_id': n}
|
|
self.ofc.create_ofc_packet_filter(self.ctx, f, pf)
|
|
self.assertTrue(self.ofc.exists_ofc_packet_filter(self.ctx, f))
|
|
|
|
def testl_delete_ofc_packet_filter(self):
|
|
"""test delete ofc_filter"""
|
|
t, n, p, f, none = self.get_random_params()
|
|
self.ofc.create_ofc_tenant(self.ctx, t)
|
|
self.ofc.create_ofc_network(self.ctx, t, n)
|
|
pf = {'tenant_id': t, 'network_id': n}
|
|
self.ofc.create_ofc_packet_filter(self.ctx, f, pf)
|
|
self.assertTrue(ndb.get_ofc_item(self.ctx.session,
|
|
'ofc_packet_filter', f))
|
|
self.ofc.delete_ofc_packet_filter(self.ctx, f)
|
|
self.assertFalse(ndb.get_ofc_item(self.ctx.session,
|
|
'ofc_packet_filter', f))
|
|
|
|
|
|
class OFCManagerTestWithOldMapping(OFCManagerTestBase, unittest.TestCase):
|
|
|
|
def test_exists_ofc_tenant(self):
|
|
t, n, p, f, none = self.get_random_params()
|
|
ofc_t, ofc_n, ofc_p, ofc_f, ofc_none = self.get_random_params()
|
|
|
|
self.assertFalse(self.ofc.exists_ofc_tenant(self.ctx, t))
|
|
|
|
session = self.ctx.session
|
|
ndb.add_ofc_item(session, 'ofc_tenant', t, ofc_t, old_style=True)
|
|
self.assertTrue(self.ofc.exists_ofc_tenant(self.ctx, t))
|
|
|
|
def test_delete_ofc_tenant(self):
|
|
t, n, p, f, none = self.get_random_params()
|
|
ofc_t, ofc_n, ofc_p, ofc_f, ofc_none = self.get_random_params()
|
|
|
|
self.assertFalse(self.ofc.exists_ofc_tenant(self.ctx, t))
|
|
|
|
session = self.ctx.session
|
|
ndb.add_ofc_item(session, 'ofc_tenant', t, ofc_t, old_style=True)
|
|
self.assertTrue(self.ofc.exists_ofc_tenant(self.ctx, t))
|
|
|
|
self.ofc.delete_ofc_tenant(self.ctx, t)
|
|
self.assertFalse(self.ofc.exists_ofc_tenant(self.ctx, t))
|
|
|
|
def test_exists_ofc_network(self):
|
|
t, n, p, f, none = self.get_random_params()
|
|
ofc_t, ofc_n, ofc_p, ofc_f, ofc_none = self.get_random_params()
|
|
|
|
self.assertFalse(self.ofc.exists_ofc_network(self.ctx, n))
|
|
|
|
session = self.ctx.session
|
|
ndb.add_ofc_item(session, 'ofc_network', n, ofc_n, old_style=True)
|
|
self.assertTrue(self.ofc.exists_ofc_network(self.ctx, n))
|
|
|
|
def test_delete_ofc_network(self):
|
|
t, n, p, f, none = self.get_random_params()
|
|
ofc_t, ofc_n, ofc_p, ofc_f, ofc_none = self.get_random_params()
|
|
|
|
self.assertFalse(self.ofc.exists_ofc_network(self.ctx, n))
|
|
|
|
session = self.ctx.session
|
|
ndb.add_ofc_item(session, 'ofc_network', n, ofc_n, old_style=True)
|
|
self.assertTrue(self.ofc.exists_ofc_network(self.ctx, n))
|
|
|
|
net = {'tenant_id': t}
|
|
self.ofc.delete_ofc_network(self.ctx, n, net)
|
|
self.assertFalse(self.ofc.exists_ofc_network(self.ctx, n))
|
|
|
|
def test_exists_ofc_port(self):
|
|
t, n, p, f, none = self.get_random_params()
|
|
ofc_t, ofc_n, ofc_p, ofc_f, ofc_none = self.get_random_params()
|
|
|
|
self.assertFalse(self.ofc.exists_ofc_port(self.ctx, p))
|
|
|
|
session = self.ctx.session
|
|
ndb.add_ofc_item(session, 'ofc_port', p, ofc_p, old_style=True)
|
|
self.assertTrue(self.ofc.exists_ofc_port(self.ctx, p))
|
|
|
|
def test_delete_ofc_port(self):
|
|
t, n, p, f, none = self.get_random_params()
|
|
ofc_t, ofc_n, ofc_p, ofc_f, ofc_none = self.get_random_params()
|
|
|
|
self.assertFalse(self.ofc.exists_ofc_port(self.ctx, p))
|
|
|
|
session = self.ctx.session
|
|
ndb.add_ofc_item(session, 'ofc_port', p, ofc_p, old_style=True)
|
|
self.assertTrue(self.ofc.exists_ofc_port(self.ctx, p))
|
|
|
|
port = {'tenant_id': t, 'network_id': n}
|
|
self.ofc.delete_ofc_port(self.ctx, p, port)
|
|
self.assertFalse(self.ofc.exists_ofc_port(self.ctx, p))
|
|
|
|
def test_exists_ofc_packet_filter(self):
|
|
t, n, p, f, none = self.get_random_params()
|
|
ofc_t, ofc_n, ofc_p, ofc_f, ofc_none = self.get_random_params()
|
|
|
|
self.assertFalse(self.ofc.exists_ofc_packet_filter(self.ctx, f))
|
|
|
|
session = self.ctx.session
|
|
ndb.add_ofc_item(session, 'ofc_packet_filter', f, ofc_f,
|
|
old_style=True)
|
|
self.assertTrue(self.ofc.exists_ofc_packet_filter(self.ctx, f))
|
|
|
|
def test_delete_ofc_packet_filter(self):
|
|
t, n, p, f, none = self.get_random_params()
|
|
ofc_t, ofc_n, ofc_p, ofc_f, ofc_none = self.get_random_params()
|
|
|
|
self.assertFalse(self.ofc.exists_ofc_packet_filter(self.ctx, f))
|
|
|
|
session = self.ctx.session
|
|
ndb.add_ofc_item(session, 'ofc_packet_filter', f, ofc_f,
|
|
old_style=True)
|
|
self.assertTrue(self.ofc.exists_ofc_packet_filter(self.ctx, f))
|
|
|
|
self.ofc.delete_ofc_packet_filter(self.ctx, f)
|
|
self.assertFalse(self.ofc.exists_ofc_packet_filter(self.ctx, f))
|