56ab50beaf
prereq for bp quantum-l3-fw-nat - make init_l3 take cidrs, rather than assuming an augmented port object - make namespace for agent operations optional and allow the namespace name to be configured. - allow plug() operation to take an optional bridge parameter indicating which bridge to plug into - add namespace support for iptables manager - make OVS plug() set the IP address, etc. of a device even if it already exists. Change-Id: Id4fec9bf7cda30c45b94eccd25e9e54dc5af97b7
464 lines
18 KiB
Python
464 lines
18 KiB
Python
# vim: tabstop=4 shiftwidth=4 softtabstop=4
|
|
|
|
# Copyright 2012 OpenStack LLC
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import mock
|
|
import unittest2 as unittest
|
|
|
|
from quantum.agent.linux import ip_lib
|
|
from quantum.agent.linux import utils
|
|
from quantum.common import exceptions
|
|
|
|
NETNS_SAMPLE = [
|
|
'12345678-1234-5678-abcd-1234567890ab',
|
|
'bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb',
|
|
'cccccccc-cccc-cccc-cccc-cccccccccccc']
|
|
|
|
LINK_SAMPLE = [
|
|
'1: lo: <LOOPBACK,UP,LOWER_UP> mtu 16436 qdisc noqueue state UNKNOWN \\'
|
|
'link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00',
|
|
'2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP '
|
|
'qlen 1000\ link/ether cc:dd:ee:ff:ab:cd brd ff:ff:ff:ff:ff:ff',
|
|
'3: br-int: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN '
|
|
'\ link/ether aa:bb:cc:dd:ee:ff brd ff:ff:ff:ff:ff:ff',
|
|
'4: gw-ddc717df-49: <BROADCAST,MULTICAST> mtu 1500 qdisc noop '
|
|
'state DOWN \ link/ether fe:dc:ba:fe:dc:ba brd ff:ff:ff:ff:ff:ff']
|
|
|
|
ADDR_SAMPLE = ("""
|
|
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP qlen 1000
|
|
link/ether dd:cc:aa:b9:76:ce brd ff:ff:ff:ff:ff:ff
|
|
inet 172.16.77.240/24 brd 172.16.77.255 scope global eth0
|
|
inet6 2001:470:9:1224:5595:dd51:6ba2:e788/64 scope global temporary dynamic
|
|
valid_lft 14187sec preferred_lft 3387sec
|
|
inet6 2001:470:9:1224:fd91:272:581e:3a32/64 scope global temporary """
|
|
"""deprecated dynamic
|
|
valid_lft 14187sec preferred_lft 0sec
|
|
inet6 2001:470:9:1224:4508:b885:5fb:740b/64 scope global temporary """
|
|
"""deprecated dynamic
|
|
valid_lft 14187sec preferred_lft 0sec
|
|
inet6 2001:470:9:1224:dfcc:aaff:feb9:76ce/64 scope global dynamic
|
|
valid_lft 14187sec preferred_lft 3387sec
|
|
inet6 fe80::dfcc:aaff:feb9:76ce/64 scope link
|
|
valid_lft forever preferred_lft forever
|
|
""")
|
|
|
|
|
|
class TestSubProcessBase(unittest.TestCase):
|
|
def setUp(self):
|
|
self.execute_p = mock.patch('quantum.agent.linux.utils.execute')
|
|
self.execute = self.execute_p.start()
|
|
|
|
def tearDown(self):
|
|
self.execute_p.stop()
|
|
|
|
def test_execute_wrapper(self):
|
|
ip_lib.SubProcessBase._execute('o', 'link', ('list',), 'sudo')
|
|
|
|
self.execute.assert_called_once_with(['ip', '-o', 'link', 'list'],
|
|
root_helper='sudo')
|
|
|
|
def test_execute_wrapper_int_options(self):
|
|
ip_lib.SubProcessBase._execute([4], 'link', ('list',))
|
|
|
|
self.execute.assert_called_once_with(['ip', '-4', 'link', 'list'],
|
|
root_helper=None)
|
|
|
|
def test_execute_wrapper_no_options(self):
|
|
ip_lib.SubProcessBase._execute([], 'link', ('list',))
|
|
|
|
self.execute.assert_called_once_with(['ip', 'link', 'list'],
|
|
root_helper=None)
|
|
|
|
def test_run_no_namespace(self):
|
|
base = ip_lib.SubProcessBase('sudo')
|
|
base._run([], 'link', ('list',))
|
|
self.execute.assert_called_once_with(['ip', 'link', 'list'],
|
|
root_helper=None)
|
|
|
|
def test_run_namespace(self):
|
|
base = ip_lib.SubProcessBase('sudo', 'ns')
|
|
base._run([], 'link', ('list',))
|
|
self.execute.assert_called_once_with(['ip', 'netns', 'exec', 'ns',
|
|
'ip', 'link', 'list'],
|
|
root_helper='sudo')
|
|
|
|
def test_as_root_namespace(self):
|
|
base = ip_lib.SubProcessBase('sudo', 'ns')
|
|
base._as_root([], 'link', ('list',))
|
|
self.execute.assert_called_once_with(['ip', 'netns', 'exec', 'ns',
|
|
'ip', 'link', 'list'],
|
|
root_helper='sudo')
|
|
|
|
def test_as_root_no_root_helper(self):
|
|
base = ip_lib.SubProcessBase()
|
|
self.assertRaises(exceptions.SudoRequired,
|
|
base._as_root,
|
|
[], 'link', ('list',))
|
|
|
|
|
|
class TestIpWrapper(unittest.TestCase):
|
|
def setUp(self):
|
|
self.execute_p = mock.patch.object(ip_lib.IPWrapper, '_execute')
|
|
self.execute = self.execute_p.start()
|
|
|
|
def tearDown(self):
|
|
self.execute_p.stop()
|
|
|
|
def test_get_devices(self):
|
|
self.execute.return_value = '\n'.join(LINK_SAMPLE)
|
|
retval = ip_lib.IPWrapper('sudo').get_devices()
|
|
self.assertEquals(retval,
|
|
[ip_lib.IPDevice('lo'),
|
|
ip_lib.IPDevice('eth0'),
|
|
ip_lib.IPDevice('br-int'),
|
|
ip_lib.IPDevice('gw-ddc717df-49')])
|
|
|
|
self.execute.assert_called_once_with('o', 'link', ('list',),
|
|
'sudo', None)
|
|
|
|
def test_get_devices_malformed_line(self):
|
|
self.execute.return_value = '\n'.join(LINK_SAMPLE + ['gibberish'])
|
|
retval = ip_lib.IPWrapper('sudo').get_devices()
|
|
self.assertEquals(retval,
|
|
[ip_lib.IPDevice('lo'),
|
|
ip_lib.IPDevice('eth0'),
|
|
ip_lib.IPDevice('br-int'),
|
|
ip_lib.IPDevice('gw-ddc717df-49')])
|
|
|
|
self.execute.assert_called_once_with('o', 'link', ('list',),
|
|
'sudo', None)
|
|
|
|
def test_get_namespaces(self):
|
|
self.execute.return_value = '\n'.join(NETNS_SAMPLE)
|
|
retval = ip_lib.IPWrapper.get_namespaces('sudo')
|
|
self.assertEquals(retval,
|
|
['12345678-1234-5678-abcd-1234567890ab',
|
|
'bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb',
|
|
'cccccccc-cccc-cccc-cccc-cccccccccccc'])
|
|
|
|
self.execute.assert_called_once_with('', 'netns', ('list',),
|
|
root_helper='sudo')
|
|
|
|
def test_add_tuntap(self):
|
|
ip_lib.IPWrapper('sudo').add_tuntap('tap0')
|
|
self.execute.assert_called_once_with('', 'tuntap',
|
|
('add', 'tap0', 'mode', 'tap'),
|
|
'sudo', None)
|
|
|
|
def test_add_veth(self):
|
|
ip_lib.IPWrapper('sudo').add_veth('tap0', 'tap1')
|
|
self.execute.assert_called_once_with('', 'link',
|
|
('add', 'tap0', 'type', 'veth',
|
|
'peer', 'name', 'tap1'),
|
|
'sudo', None)
|
|
|
|
def test_get_device(self):
|
|
dev = ip_lib.IPWrapper('sudo', 'ns').device('eth0')
|
|
self.assertEqual(dev.root_helper, 'sudo')
|
|
self.assertEqual(dev.namespace, 'ns')
|
|
self.assertEqual(dev.name, 'eth0')
|
|
|
|
def test_ensure_namespace(self):
|
|
with mock.patch.object(ip_lib, 'IPDevice') as ip_dev:
|
|
ip = ip_lib.IPWrapper('sudo')
|
|
with mock.patch.object(ip.netns, 'exists') as ns_exists:
|
|
ns_exists.return_value = False
|
|
ns = ip.ensure_namespace('ns')
|
|
self.execute.assert_has_calls(
|
|
[mock.call([], 'netns', ('add', 'ns'), 'sudo', None)])
|
|
ip_dev.assert_has_calls([mock.call('lo', 'sudo', 'ns'),
|
|
mock.call().link.set_up()])
|
|
|
|
def test_ensure_namespace_existing(self):
|
|
with mock.patch.object(ip_lib, 'IpNetnsCommand') as ip_ns_cmd:
|
|
ip_ns_cmd.exists.return_value = True
|
|
ns = ip_lib.IPWrapper('sudo').ensure_namespace('ns')
|
|
self.assertFalse(self.execute.called)
|
|
self.assertEqual(ns.namespace, 'ns')
|
|
|
|
def test_add_device_to_namespace(self):
|
|
dev = mock.Mock()
|
|
ip_lib.IPWrapper('sudo', 'ns').add_device_to_namespace(dev)
|
|
dev.assert_has_calls([mock.call.link.set_netns('ns')])
|
|
|
|
def test_add_device_to_namespace_is_none(self):
|
|
dev = mock.Mock()
|
|
ip_lib.IPWrapper('sudo').add_device_to_namespace(dev)
|
|
self.assertEqual(dev.mock_calls, [])
|
|
|
|
|
|
class TestIPDevice(unittest.TestCase):
|
|
def test_eq_same_name(self):
|
|
dev1 = ip_lib.IPDevice('tap0')
|
|
dev2 = ip_lib.IPDevice('tap0')
|
|
self.assertEqual(dev1, dev2)
|
|
|
|
def test_eq_diff_name(self):
|
|
dev1 = ip_lib.IPDevice('tap0')
|
|
dev2 = ip_lib.IPDevice('tap1')
|
|
self.assertNotEqual(dev1, dev2)
|
|
|
|
def test_eq_same_namespace(self):
|
|
dev1 = ip_lib.IPDevice('tap0', 'ns1')
|
|
dev2 = ip_lib.IPDevice('tap0', 'ns1')
|
|
self.assertEqual(dev1, dev2)
|
|
|
|
def test_eq_diff_namespace(self):
|
|
dev1 = ip_lib.IPDevice('tap0', 'sudo', 'ns1')
|
|
dev2 = ip_lib.IPDevice('tap0', 'sudo', 'ns2')
|
|
self.assertNotEqual(dev1, dev2)
|
|
|
|
def test_eq_other_is_none(self):
|
|
dev1 = ip_lib.IPDevice('tap0', 'sudo', 'ns1')
|
|
self.assertNotEqual(dev1, None)
|
|
|
|
def test_str(self):
|
|
self.assertEqual(str(ip_lib.IPDevice('tap0')), 'tap0')
|
|
|
|
|
|
class TestIPCommandBase(unittest.TestCase):
|
|
def setUp(self):
|
|
self.ip = mock.Mock()
|
|
self.ip.root_helper = 'sudo'
|
|
self.ip.namespace = 'namespace'
|
|
self.ip_cmd = ip_lib.IpCommandBase(self.ip)
|
|
self.ip_cmd.COMMAND = 'foo'
|
|
|
|
def test_run(self):
|
|
self.ip_cmd._run('link', 'show')
|
|
self.ip.assert_has_calls([mock.call._run([], 'foo', ('link', 'show'))])
|
|
|
|
def test_run_with_options(self):
|
|
self.ip_cmd._run('link', options='o')
|
|
self.ip.assert_has_calls([mock.call._run('o', 'foo', ('link', ))])
|
|
|
|
def test_as_root(self):
|
|
self.ip_cmd._as_root('link')
|
|
self.ip.assert_has_calls([mock.call._as_root([], 'foo', ('link', ))])
|
|
|
|
def test_as_root_with_options(self):
|
|
self.ip_cmd._as_root('link', options='o')
|
|
self.ip.assert_has_calls([mock.call._as_root('o', 'foo', ('link', ))])
|
|
|
|
|
|
class TestIPDeviceCommandBase(unittest.TestCase):
|
|
def setUp(self):
|
|
self.ip_dev = mock.Mock()
|
|
self.ip_dev.name = 'eth0'
|
|
self.ip_dev.root_helper = 'sudo'
|
|
self.ip_dev._execute = mock.Mock(return_value='executed')
|
|
self.ip_cmd = ip_lib.IpDeviceCommandBase(self.ip_dev)
|
|
self.ip_cmd.COMMAND = 'foo'
|
|
|
|
def test_name_property(self):
|
|
self.assertEqual(self.ip_cmd.name, 'eth0')
|
|
|
|
|
|
class TestIPCmdBase(unittest.TestCase):
|
|
def setUp(self):
|
|
self.parent = mock.Mock()
|
|
self.parent.name = 'eth0'
|
|
self.parent.root_helper = 'sudo'
|
|
|
|
def _assert_call(self, options, args):
|
|
self.parent.assert_has_calls([
|
|
mock.call._run(options, self.command, args)])
|
|
|
|
def _assert_sudo(self, options, args):
|
|
self.parent.assert_has_calls([
|
|
mock.call._as_root(options, self.command, args)])
|
|
|
|
|
|
class TestIpLinkCommand(TestIPCmdBase):
|
|
def setUp(self):
|
|
super(TestIpLinkCommand, self).setUp()
|
|
self.parent._run.return_value = LINK_SAMPLE[1]
|
|
self.command = 'link'
|
|
self.link_cmd = ip_lib.IpLinkCommand(self.parent)
|
|
|
|
def test_set_address(self):
|
|
self.link_cmd.set_address('aa:bb:cc:dd:ee:ff')
|
|
self._assert_sudo([], ('set', 'eth0', 'address', 'aa:bb:cc:dd:ee:ff'))
|
|
|
|
def test_set_mtu(self):
|
|
self.link_cmd.set_mtu(1500)
|
|
self._assert_sudo([], ('set', 'eth0', 'mtu', 1500))
|
|
|
|
def test_set_up(self):
|
|
self.link_cmd.set_up()
|
|
self._assert_sudo([], ('set', 'eth0', 'up'))
|
|
|
|
def test_set_down(self):
|
|
self.link_cmd.set_down()
|
|
self._assert_sudo([], ('set', 'eth0', 'down'))
|
|
|
|
def test_set_netns(self):
|
|
self.link_cmd.set_netns('foo')
|
|
self._assert_sudo([], ('set', 'eth0', 'netns', 'foo'))
|
|
self.assertEqual(self.parent.namespace, 'foo')
|
|
|
|
def test_set_name(self):
|
|
self.link_cmd.set_name('tap1')
|
|
self._assert_sudo([], ('set', 'eth0', 'name', 'tap1'))
|
|
self.assertEqual(self.parent.name, 'tap1')
|
|
|
|
def test_delete(self):
|
|
self.link_cmd.delete()
|
|
self._assert_sudo([], ('delete', 'eth0'))
|
|
|
|
def test_address_property(self):
|
|
self.parent._execute = mock.Mock(return_value=LINK_SAMPLE[1])
|
|
self.assertEqual(self.link_cmd.address, 'cc:dd:ee:ff:ab:cd')
|
|
|
|
def test_mtu_property(self):
|
|
self.parent._execute = mock.Mock(return_value=LINK_SAMPLE[1])
|
|
self.assertEqual(self.link_cmd.mtu, 1500)
|
|
|
|
def test_qdisc_property(self):
|
|
self.parent._execute = mock.Mock(return_value=LINK_SAMPLE[1])
|
|
self.assertEqual(self.link_cmd.qdisc, 'mq')
|
|
|
|
def test_qlen_property(self):
|
|
self.parent._execute = mock.Mock(return_value=LINK_SAMPLE[1])
|
|
self.assertEqual(self.link_cmd.qlen, 1000)
|
|
|
|
def test_state_property(self):
|
|
self.parent._execute = mock.Mock(return_value=LINK_SAMPLE[1])
|
|
self.assertEqual(self.link_cmd.state, 'UP')
|
|
|
|
def test_settings_property(self):
|
|
expected = {'mtu': 1500,
|
|
'qlen': 1000,
|
|
'state': 'UP',
|
|
'qdisc': 'mq',
|
|
'brd': 'ff:ff:ff:ff:ff:ff',
|
|
'link/ether': 'cc:dd:ee:ff:ab:cd'}
|
|
self.parent._execute = mock.Mock(return_value=LINK_SAMPLE[1])
|
|
self.assertEquals(self.link_cmd.attributes, expected)
|
|
self._assert_call('o', ('show', 'eth0'))
|
|
|
|
|
|
class TestIpAddrCommand(TestIPCmdBase):
|
|
def setUp(self):
|
|
super(TestIpAddrCommand, self).setUp()
|
|
self.parent.name = 'tap0'
|
|
self.command = 'addr'
|
|
self.addr_cmd = ip_lib.IpAddrCommand(self.parent)
|
|
|
|
def test_add_address(self):
|
|
self.addr_cmd.add(4, '192.168.45.100/24', '192.168.45.255')
|
|
self._assert_sudo([4],
|
|
('add', '192.168.45.100/24', 'brd', '192.168.45.255',
|
|
'scope', 'global', 'dev', 'tap0'))
|
|
|
|
def test_add_address_scoped(self):
|
|
self.addr_cmd.add(4, '192.168.45.100/24', '192.168.45.255',
|
|
scope='link')
|
|
self._assert_sudo([4],
|
|
('add', '192.168.45.100/24', 'brd', '192.168.45.255',
|
|
'scope', 'link', 'dev', 'tap0'))
|
|
|
|
def test_del_address(self):
|
|
self.addr_cmd.delete(4, '192.168.45.100/24')
|
|
self._assert_sudo([4],
|
|
('del', '192.168.45.100/24', 'dev', 'tap0'))
|
|
|
|
def test_flush(self):
|
|
self.addr_cmd.flush()
|
|
self._assert_sudo([], ('flush', 'tap0'))
|
|
|
|
def test_list(self):
|
|
expected = [
|
|
dict(ip_version=4, scope='global',
|
|
dynamic=False, cidr='172.16.77.240/24'),
|
|
dict(ip_version=6, scope='global',
|
|
dynamic=True, cidr='2001:470:9:1224:5595:dd51:6ba2:e788/64'),
|
|
dict(ip_version=6, scope='global',
|
|
dynamic=True, cidr='2001:470:9:1224:fd91:272:581e:3a32/64'),
|
|
dict(ip_version=6, scope='global',
|
|
dynamic=True, cidr='2001:470:9:1224:4508:b885:5fb:740b/64'),
|
|
dict(ip_version=6, scope='global',
|
|
dynamic=True, cidr='2001:470:9:1224:dfcc:aaff:feb9:76ce/64'),
|
|
dict(ip_version=6, scope='link',
|
|
dynamic=False, cidr='fe80::dfcc:aaff:feb9:76ce/64')]
|
|
|
|
self.parent._run = mock.Mock(return_value=ADDR_SAMPLE)
|
|
self.assertEquals(self.addr_cmd.list(), expected)
|
|
self._assert_call([], ('show', 'tap0'))
|
|
|
|
def test_list_filtered(self):
|
|
expected = [
|
|
dict(ip_version=4, scope='global',
|
|
dynamic=False, cidr='172.16.77.240/24')]
|
|
|
|
output = '\n'.join(ADDR_SAMPLE.split('\n')[0:4])
|
|
self.parent._run.return_value = output
|
|
self.assertEquals(self.addr_cmd.list('global', filters=['permanent']),
|
|
expected)
|
|
self._assert_call([], ('show', 'tap0', 'permanent', 'scope', 'global'))
|
|
|
|
|
|
class TestIpNetnsCommand(TestIPCmdBase):
|
|
def setUp(self):
|
|
super(TestIpNetnsCommand, self).setUp()
|
|
self.command = 'netns'
|
|
self.netns_cmd = ip_lib.IpNetnsCommand(self.parent)
|
|
|
|
def test_add_namespace(self):
|
|
ns = self.netns_cmd.add('ns')
|
|
self._assert_sudo([], ('add', 'ns'))
|
|
self.assertEqual(ns.namespace, 'ns')
|
|
|
|
def test_delete_namespace(self):
|
|
self.netns_cmd.delete('ns')
|
|
self._assert_sudo([], ('delete', 'ns'))
|
|
|
|
def test_namespace_exists(self):
|
|
retval = '\n'.join(NETNS_SAMPLE)
|
|
self.parent._as_root.return_value = retval
|
|
self.assertTrue(
|
|
self.netns_cmd.exists('bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb'))
|
|
self._assert_sudo('o', ('list',))
|
|
|
|
def test_namespace_doest_not_exist(self):
|
|
retval = '\n'.join(NETNS_SAMPLE)
|
|
self.parent._as_root.return_value = retval
|
|
self.assertFalse(
|
|
self.netns_cmd.exists('bbbbbbbb-1111-2222-3333-bbbbbbbbbbbb'))
|
|
self._assert_sudo('o', ('list',))
|
|
|
|
def test_execute(self):
|
|
self.parent.namespace = 'ns'
|
|
with mock.patch('quantum.agent.linux.utils.execute') as execute:
|
|
self.netns_cmd.execute(['ip', 'link', 'list'])
|
|
execute.assert_called_once_with(['ip', 'netns', 'exec', 'ns', 'ip',
|
|
'link', 'list'],
|
|
root_helper='sudo')
|
|
|
|
|
|
class TestDeviceExists(unittest.TestCase):
|
|
def test_device_exists(self):
|
|
with mock.patch.object(ip_lib.IPDevice, '_execute') as _execute:
|
|
_execute.return_value = LINK_SAMPLE[1]
|
|
self.assertTrue(ip_lib.device_exists('eth0'))
|
|
_execute.assert_called_once_with('o', 'link', ('show', 'eth0'))
|
|
|
|
def test_device_does_not_exist(self):
|
|
with mock.patch.object(ip_lib.IPDevice, '_execute') as _execute:
|
|
_execute.return_value = ''
|
|
_execute.side_effect = RuntimeError
|
|
self.assertFalse(ip_lib.device_exists('eth0'))
|