bf6bd01286
TestL3GwModeMixin can fail randomly because it doesn't initialize core_plugin and can be run random core plugin depending on execution order of tests. It also fails with core plugin uninitialized when it is run without other tests. This patch refactors the setup code of core plugin and apply it to the related tests. This patch reveled the same bug of test_metaplugin.py which is also fixed by this patch. Closes-bug: #1273259 Change-Id: I3c1d4d8b3d69262b89c7747daa8267bf2c8e7f6b
160 lines
6.6 KiB
Python
160 lines
6.6 KiB
Python
# vim: tabstop=4 shiftwidth=4 softtabstop=4
|
|
|
|
# Copyright (c) 2012 OpenStack Foundation.
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import os
|
|
import types
|
|
|
|
import fixtures
|
|
|
|
from oslo.config import cfg
|
|
|
|
from neutron.common import config
|
|
from neutron.manager import NeutronManager
|
|
from neutron.manager import validate_post_plugin_load
|
|
from neutron.manager import validate_pre_plugin_load
|
|
from neutron.openstack.common import log as logging
|
|
from neutron.plugins.common import constants
|
|
from neutron.tests import base
|
|
from neutron.tests.unit import dummy_plugin
|
|
|
|
|
|
LOG = logging.getLogger(__name__)
|
|
DB_PLUGIN_KLASS = 'neutron.db.db_base_plugin_v2.NeutronDbPluginV2'
|
|
ROOTDIR = os.path.dirname(os.path.dirname(__file__))
|
|
ETCDIR = os.path.join(ROOTDIR, 'etc')
|
|
|
|
|
|
def etcdir(*p):
|
|
return os.path.join(ETCDIR, *p)
|
|
|
|
|
|
class MultiServiceCorePlugin(object):
|
|
supported_extension_aliases = ['lbaas', 'dummy']
|
|
|
|
|
|
class CorePluginWithAgentNotifiers(object):
|
|
agent_notifiers = {'l3': 'l3_agent_notifier',
|
|
'dhcp': 'dhcp_agent_notifier'}
|
|
|
|
|
|
class NeutronManagerTestCase(base.BaseTestCase):
|
|
|
|
def setUp(self):
|
|
super(NeutronManagerTestCase, self).setUp()
|
|
args = ['--config-file', etcdir('neutron.conf.test')]
|
|
# If test_config specifies some config-file, use it, as well
|
|
config.parse(args=args)
|
|
self.setup_coreplugin()
|
|
self.addCleanup(cfg.CONF.reset)
|
|
self.useFixture(
|
|
fixtures.MonkeyPatch('neutron.manager.NeutronManager._instance'))
|
|
|
|
def test_service_plugin_is_loaded(self):
|
|
cfg.CONF.set_override("core_plugin", DB_PLUGIN_KLASS)
|
|
cfg.CONF.set_override("service_plugins",
|
|
["neutron.tests.unit.dummy_plugin."
|
|
"DummyServicePlugin"])
|
|
mgr = NeutronManager.get_instance()
|
|
plugin = mgr.get_service_plugins()[constants.DUMMY]
|
|
|
|
self.assertTrue(
|
|
isinstance(plugin,
|
|
(dummy_plugin.DummyServicePlugin, types.ClassType)),
|
|
"loaded plugin should be of type neutronDummyPlugin")
|
|
|
|
def test_service_plugin_by_name_is_loaded(self):
|
|
cfg.CONF.set_override("core_plugin", DB_PLUGIN_KLASS)
|
|
cfg.CONF.set_override("service_plugins", ["dummy"])
|
|
mgr = NeutronManager.get_instance()
|
|
plugin = mgr.get_service_plugins()[constants.DUMMY]
|
|
|
|
self.assertTrue(
|
|
isinstance(plugin,
|
|
(dummy_plugin.DummyServicePlugin, types.ClassType)),
|
|
"loaded plugin should be of type neutronDummyPlugin")
|
|
|
|
def test_multiple_plugins_specified_for_service_type(self):
|
|
cfg.CONF.set_override("service_plugins",
|
|
["neutron.tests.unit.dummy_plugin."
|
|
"DummyServicePlugin",
|
|
"neutron.tests.unit.dummy_plugin."
|
|
"DummyServicePlugin"])
|
|
cfg.CONF.set_override("core_plugin", DB_PLUGIN_KLASS)
|
|
self.assertRaises(ValueError, NeutronManager.get_instance)
|
|
|
|
def test_multiple_plugins_by_name_specified_for_service_type(self):
|
|
cfg.CONF.set_override("service_plugins", ["dummy", "dummy"])
|
|
cfg.CONF.set_override("core_plugin", DB_PLUGIN_KLASS)
|
|
self.assertRaises(ValueError, NeutronManager.get_instance)
|
|
|
|
def test_multiple_plugins_mixed_specified_for_service_type(self):
|
|
cfg.CONF.set_override("service_plugins",
|
|
["neutron.tests.unit.dummy_plugin."
|
|
"DummyServicePlugin", "dummy"])
|
|
cfg.CONF.set_override("core_plugin", DB_PLUGIN_KLASS)
|
|
self.assertRaises(ValueError, NeutronManager.get_instance)
|
|
|
|
def test_service_plugin_conflicts_with_core_plugin(self):
|
|
cfg.CONF.set_override("service_plugins",
|
|
["neutron.tests.unit.dummy_plugin."
|
|
"DummyServicePlugin"])
|
|
cfg.CONF.set_override("core_plugin",
|
|
"neutron.tests.unit.test_neutron_manager."
|
|
"MultiServiceCorePlugin")
|
|
self.assertRaises(ValueError, NeutronManager.get_instance)
|
|
|
|
def test_core_plugin_supports_services(self):
|
|
cfg.CONF.set_override("core_plugin",
|
|
"neutron.tests.unit.test_neutron_manager."
|
|
"MultiServiceCorePlugin")
|
|
mgr = NeutronManager.get_instance()
|
|
svc_plugins = mgr.get_service_plugins()
|
|
self.assertEqual(3, len(svc_plugins))
|
|
self.assertIn(constants.CORE, svc_plugins.keys())
|
|
self.assertIn(constants.LOADBALANCER, svc_plugins.keys())
|
|
self.assertIn(constants.DUMMY, svc_plugins.keys())
|
|
|
|
def test_post_plugin_validation(self):
|
|
cfg.CONF.import_opt('dhcp_agents_per_network',
|
|
'neutron.db.agentschedulers_db')
|
|
|
|
self.assertIsNone(validate_post_plugin_load())
|
|
cfg.CONF.set_override('dhcp_agents_per_network', 2)
|
|
self.assertIsNone(validate_post_plugin_load())
|
|
cfg.CONF.set_override('dhcp_agents_per_network', 0)
|
|
self.assertIsNotNone(validate_post_plugin_load())
|
|
cfg.CONF.set_override('dhcp_agents_per_network', -1)
|
|
self.assertIsNotNone(validate_post_plugin_load())
|
|
|
|
def test_pre_plugin_validation(self):
|
|
self.assertIsNotNone(validate_pre_plugin_load())
|
|
cfg.CONF.set_override('core_plugin', 'dummy.plugin')
|
|
self.assertIsNone(validate_pre_plugin_load())
|
|
|
|
def test_manager_gathers_agent_notifiers_from_service_plugins(self):
|
|
cfg.CONF.set_override("service_plugins",
|
|
["neutron.tests.unit.dummy_plugin."
|
|
"DummyServicePlugin"])
|
|
cfg.CONF.set_override("core_plugin",
|
|
"neutron.tests.unit.test_neutron_manager."
|
|
"CorePluginWithAgentNotifiers")
|
|
expected = {'l3': 'l3_agent_notifier',
|
|
'dhcp': 'dhcp_agent_notifier',
|
|
'dummy': 'dummy_agent_notifier'}
|
|
core_plugin = NeutronManager.get_plugin()
|
|
self.assertEqual(expected, core_plugin.agent_notifiers)
|