fad8f4098f
When Noop Firewall driver is used, Quantum security group actually does nothing in OVS and Linux Bridge plugin. It would be better to disable security group extension for such case to avoid confusion. By this we can determine whether quantum security group is enabled by checking the extension list. This commit changes OVS/LB/NEC/Ryu plugins with agent firewall_driver based security group implementation. Fixes bug #1124117 Change-Id: I2182289c1e27987b686f1adb7d6e2ad4e154caa2
103 lines
4.4 KiB
Python
103 lines
4.4 KiB
Python
# vim: tabstop=4 shiftwidth=4 softtabstop=4
|
|
#
|
|
# Copyright 2012, Nachi Ueno, NTT MCL, Inc.
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import mock
|
|
|
|
from quantum.api.v2 import attributes
|
|
from quantum.extensions import securitygroup as ext_sg
|
|
from quantum.plugins.linuxbridge.db import l2network_db_v2 as lb_db
|
|
from quantum.tests.unit import test_extension_security_group as test_sg
|
|
from quantum.tests.unit import test_security_groups_rpc as test_sg_rpc
|
|
|
|
|
|
PLUGIN_NAME = ('quantum.plugins.linuxbridge.'
|
|
'lb_quantum_plugin.LinuxBridgePluginV2')
|
|
AGENT_NAME = ('quantum.plugins.linuxbridge.'
|
|
'agent.linuxbridg_quantum_agent.LinuxBridgeQuantumAgentRPC')
|
|
NOTIFIER = ('quantum.plugins.linuxbridge.'
|
|
'lb_quantum_plugin.AgentNotifierApi')
|
|
|
|
|
|
class LinuxBridgeSecurityGroupsTestCase(test_sg.SecurityGroupDBTestCase):
|
|
_plugin_name = PLUGIN_NAME
|
|
|
|
def setUp(self, plugin=None):
|
|
test_sg_rpc.set_firewall_driver(test_sg_rpc.FIREWALL_IPTABLES_DRIVER)
|
|
notifier_p = mock.patch(NOTIFIER)
|
|
notifier_cls = notifier_p.start()
|
|
self.notifier = mock.Mock()
|
|
notifier_cls.return_value = self.notifier
|
|
self._attribute_map_bk_ = {}
|
|
for item in attributes.RESOURCE_ATTRIBUTE_MAP:
|
|
self._attribute_map_bk_[item] = (attributes.
|
|
RESOURCE_ATTRIBUTE_MAP[item].
|
|
copy())
|
|
super(LinuxBridgeSecurityGroupsTestCase, self).setUp(PLUGIN_NAME)
|
|
self.addCleanup(mock.patch.stopall)
|
|
|
|
def tearDown(self):
|
|
attributes.RESOURCE_ATTRIBUTE_MAP = self._attribute_map_bk_
|
|
super(LinuxBridgeSecurityGroupsTestCase, self).tearDown()
|
|
|
|
|
|
class TestLinuxBridgeSecurityGroups(LinuxBridgeSecurityGroupsTestCase,
|
|
test_sg.TestSecurityGroups,
|
|
test_sg_rpc.SGNotificationTestMixin):
|
|
pass
|
|
|
|
|
|
class TestLinuxBridgeSecurityGroupsXML(TestLinuxBridgeSecurityGroups):
|
|
fmt = 'xml'
|
|
|
|
|
|
class TestLinuxBridgeSecurityGroupsDB(LinuxBridgeSecurityGroupsTestCase):
|
|
def test_security_group_get_port_from_device(self):
|
|
with self.network() as n:
|
|
with self.subnet(n):
|
|
with self.security_group() as sg:
|
|
security_group_id = sg['security_group']['id']
|
|
res = self._create_port(self.fmt, n['network']['id'])
|
|
port = self.deserialize(self.fmt, res)
|
|
fixed_ips = port['port']['fixed_ips']
|
|
data = {'port': {'fixed_ips': fixed_ips,
|
|
'name': port['port']['name'],
|
|
ext_sg.SECURITYGROUPS:
|
|
[security_group_id]}}
|
|
|
|
req = self.new_update_request('ports', data,
|
|
port['port']['id'])
|
|
res = self.deserialize(self.fmt,
|
|
req.get_response(self.api))
|
|
port_id = res['port']['id']
|
|
device_id = port_id[:8]
|
|
port_dict = lb_db.get_port_from_device(device_id)
|
|
self.assertEqual(port_id, port_dict['id'])
|
|
self.assertEqual([security_group_id],
|
|
port_dict[ext_sg.SECURITYGROUPS])
|
|
self.assertEqual([], port_dict['security_group_rules'])
|
|
self.assertEqual([fixed_ips[0]['ip_address']],
|
|
port_dict['fixed_ips'])
|
|
self._delete('ports', port['port']['id'])
|
|
|
|
def test_security_group_get_port_from_device_with_no_port(self):
|
|
port_dict = lb_db.get_port_from_device('bad_device_id')
|
|
self.assertEqual(None, port_dict)
|
|
|
|
|
|
class TestLinuxBridgeSecurityGroupsDBXML(TestLinuxBridgeSecurityGroupsDB):
|
|
fmt = 'xml'
|