x/vmware-nsxlib
Code Issues Proposed changes

NSXP LB: Remove monitor only if pool has it

Browse Source 
The code attempts to remove a monitor from the pool even if the pool doesn't
use the monitor.
Although this condition is invalid, it may occur due to inconsistencies
between Neutron and the backend.
When such inconsistency occurs, we could raise an exception. But, as this is
a delete operation, and the users wants this to be gone - if it's not there,
then we are good...

Change-Id: Ifce56be6846b85130ea716c95a11be4d33db177b
This commit is contained in:
Kobi Samoray 2019-02-13 17:07:28 +02:00
parent 3c6b72e002
commit b48b84b19b
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
vmware_nsxlib/v3/policy/lb_resources.py
View File

@ -425,8 +425,9 @@ class NsxPolicyLoadBalancerPoolApi(NsxPolicyResourceBase):
lb_pool_id=lb_pool_id, tenant=tenant)
lb_pool = self.policy_api.get(lb_pool_def)
monitor_paths = lb_pool.get('active_monitor_paths', [])
monitor_paths.remove(monitor_path)
self.update(lb_pool_id, active_monitor_paths=monitor_paths)
if monitor_path in monitor_paths:
monitor_paths.remove(monitor_path)
self.update(lb_pool_id, active_monitor_paths=monitor_paths)
def create_pool_member_and_add_to_pool(
self, lb_pool_id, ip_address, port=None,