zuul/nodepool
Code Issues Proposed changes

Stop passing cloud config name to shade

Browse Source 
In 150f266 we started passing the cloud config object into shade. This
causes a TypeError[1] because the keyword cloud_config argument
overrides the positional argument. We no longer need to pass in the
cloud_config name because the cloud_config object contains it and shade
is able retrieve the name from the object[2].

[1] http://paste.openstack.org/show/412441/
[2] http://git.openstack.org/cgit/openstack-infra/shade/tree/shade/__init__.py#n228

Change-Id: Ic10869245760d17ff285623d4558712ed1773239
This commit is contained in:
Colleen Murphy 2015-08-10 14:06:13 -07:00
parent 73025c82e5
commit 1ef8c7fdaf
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
nodepool/provider_manager.py
View File

@ -287,7 +287,6 @@ class ProviderManager(TaskManager):
def _getClient(self):
return shade.OpenStackCloud(
self.provider.cloud_config.name,
cloud_config=self.provider.cloud_config,
**self.provider.cloud_config.config)