zuul/nodepool
Code Issues Proposed changes

Rename ASRT -> AGT

Browse Source 
Rename the AllocationSubRequestTarget to AllocationGrantTarget
as well as creating a new AllocationGrant class.  Currently
the AllocationSubRequest does double duty representing a request
before it's granted as well as after.  The new class takes on
the second role to make it more clear both in the code as well
as in debug output that the sub-request has transitioned from
a request to a grant.  Hopefully an AllocationGrantTarget also
makes it more clear that it holds the information about where
the nodes supplied in a grant are destined to end up.

This is not intended to produce a behavioral change other than
in debug output.

Change-Id: I8b44c35b3a99a8a3b818519a6116a74e75ced2c8
This commit is contained in:
James E. Blair 2013-10-11 11:19:04 -07:00
parent 04206cd8a0
commit 2f74d698b8
2 changed files with 45 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
nodepool/allocation.py
View File

@ -117,12 +117,12 @@ class AllocationRequest(object):
s = self.sub_requests.get(provider)
if not s:
s = AllocationSubRequest(self, provider)
asrt = s.addTarget(self.request_targets[target])
agt = s.addTarget(self.request_targets[target])
self.sub_requests[provider] = s
if s not in provider.sub_requests:
provider.sub_requests.append(s)
self.makeRequests()
return s, asrt
return s, agt
def makeRequests(self):
# (Re-)distribute this request across all of its providers.
@ -151,9 +151,9 @@ class AllocationSubRequest(object):
self.provider.name)
def addTarget(self, request_target):
asrt = AllocationSubRequestTarget(self, request_target)
self.targets.append(asrt)
return asrt
agt = AllocationGrantTarget(self, request_target)
self.targets.append(agt)
return agt
def setAmount(self, amount):
self.amount = amount
@ -170,8 +170,12 @@ class AllocationSubRequest(object):
self.provider.sub_requests.remove(self)
del self.request.sub_requests[self.provider]
if amount > 0:
grant = AllocationGrant(self.request, self.provider,
amount, self.targets)
# This is now a grant instead of a request.
self.provider.grants.append(self)
self.provider.grants.append(grant)
else:
grant = None
self.amount = amount
# Adjust provider and request values accordingly.
self.request.amount -= amount
@ -179,18 +183,34 @@ class AllocationSubRequest(object):
# Adjust the requested values for related sub-requests.
self.request.makeRequests()
# Allocate these granted nodes to targets.
self.makeAllocations()
if grant:
grant.makeAllocations()
class AllocationGrant(object):
"""A grant of a certain number of nodes of an image from a
specific provider."""
def __init__(self, request, provider, amount, targets):
self.request = request
self.provider = provider
self.amount = amount
self.targets = targets
def __repr__(self):
return '<AllocationGrant of %s of %s from %s>' % (
self.amount, self.request.name, self.provider.name)
def makeAllocations(self):
# Allocate this grant to the linked targets using min_ready as
# a weight. Calculate the total min_ready.
total_min_ready = 0.0
for asrt in self.targets:
total_min_ready += asrt.request_target.min_ready
for agt in self.targets:
total_min_ready += agt.request_target.min_ready
amount = self.amount
for asrt in self.targets:
for agt in self.targets:
if total_min_ready:
ratio = float(asrt.request_target.min_ready) / total_min_ready
ratio = float(agt.request_target.min_ready) / total_min_ready
else:
ratio = 0.0
allocation = int(round(amount * ratio))
@ -198,9 +218,9 @@ class AllocationSubRequest(object):
# grant by this amount.
amount -= allocation
# Similarly we have reduced the total weight.
total_min_ready -= asrt.request_target.min_ready
total_min_ready -= agt.request_target.min_ready
# Set the amount of this allocation.
asrt.allocate(allocation)
agt.allocate(allocation)
class AllocationTarget(object):
@ -220,15 +240,15 @@ class AllocationRequestTarget(object):
self.min_ready = min_ready
class AllocationSubRequestTarget(object):
"""A target for a specific sub-request to which nodes may be assigned."""
class AllocationGrantTarget(object):
"""A target for a specific grant to which nodes may be assigned."""
def __init__(self, sub_request, request_target):
self.sub_request = sub_request
self.request_target = request_target
self.amount = 0
def __repr__(self):
return '<AllocationSubRequestTarget for %s of %s to %s>' % (
return '<AllocationGrantTarget for %s of %s to %s>' % (
self.amount, self.sub_request.request.name,
self.request_target.target.name)

18
nodepool/nodepool.py
View File

@ -867,8 +867,8 @@ class NodePool(threading.Thread):
# "Target-Image-Provider" -- the triplet of info that identifies
# the source and location of each node. The mapping is
# AllocationSubRequestTarget -> TargetImageProvider, because
# the allocation system produces ASRTs as the final product.
# AllocationGrantTarget -> TargetImageProvider, because
# the allocation system produces AGTs as the final product.
tips = {}
# image_name -> AllocationRequest
allocation_requests = {}
@ -892,9 +892,9 @@ class NodePool(threading.Thread):
# This request may be supplied by this provider
# (and nodes from this provider supplying this
# request should be distributed to this target).
sr, asrt = ar.addProvider(
sr, agt = ar.addProvider(
allocation_providers[provider.name], at)
tips[asrt] = provider
tips[agt] = provider
self.log.debug(" Allocation requests:")
for ar in allocation_requests.values():
@ -905,16 +905,16 @@ class NodePool(threading.Thread):
nodes_to_launch = {}
# Let the allocation system do it's thing, and then examine
# the ASRT objects that it produces.
# the AGT objects that it produces.
self.log.debug(" Grants:")
for ap in allocation_providers.values():
ap.makeGrants()
for g in ap.grants:
self.log.debug(' %s' % g)
for asrt in g.targets:
self.log.debug(' %s' % asrt)
tip = tips[asrt]
nodes_to_launch[tip] = asrt.amount
for agt in g.targets:
self.log.debug(' %s' % agt)
tip = tips[agt]
nodes_to_launch[tip] = agt.amount
self.log.debug("Finished node launch calculation")
return nodes_to_launch