zuul/nodepool
Code Issues Proposed changes

Default min-ready to 0

Browse Source 
This is a more sensible default for most people, and friendlier
to new users.  Also, expand on the docs a bit.

Change-Id: I6f2c61ca423fba598c93fe5b26786dfa2711efb2
This commit is contained in:
James E. Blair 2018-02-08 12:12:43 -08:00
parent 8784158c75
commit 9f2230ab14
2 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
doc/source/configuration.rst
View File

@ -107,10 +107,16 @@ written to run on nodes of a certain label. Example::
this is exceeded the node will be deleted. A value of 0 disables this.
Defaults to 0.
``min-ready`` (default: 2)
Minimum instances that should be in a ready state. Set to -1 to have the
label considered disabled. ``min-ready`` is best-effort based on available
capacity and is not a guaranteed allocation.
``min-ready`` (default: 0)
Minimum number of instances that should be in a ready
state. Nodepool always creates more nodes as necessary in response
to demand, but setting ``min-ready`` can speed processing by
attempting to keep nodes on-hand and ready for immedate use.
``min-ready`` is best-effort based on available capacity and is
not a guaranteed allocation. The default of 0 means that nodepool
will only create nodes of this label when there is demand. Set
to -1 to have the label considered disabled, so that no nodes will
be created at all.
.. _diskimages:

2
nodepool/config.py
View File

@ -146,7 +146,7 @@ def loadConfig(config_path):
l.name = label['name']
newconfig.labels[l.name] = l
l.max_ready_age = label.get('max-ready-age', 0)
l.min_ready = label.get('min-ready', 2)
l.min_ready = label.get('min-ready', 0)
l.pools = []
for provider in config.get('providers', []):